tag 1f7148480931573b762a39e86edbd640f0460bab
tagger Geert Uytterhoeven <geert+renesas@glider.be> Tue Aug 30 15:05:03 2016 +0200
object 1f1f433e5e975b00a52839d0939c56d5879d32f1

renesas-drivers-2016-08-30-v4.8-rc4 based on renesas-devel-20160829-v4.8-rc4

commit 1f1f433e5e975b00a52839d0939c56d5879d32f1
author Geert Uytterhoeven <geert+renesas@glider.be> Tue Aug 09 17:16:17 2016 +0200
committer Geert Uytterhoeven <geert+renesas@glider.be> Tue Aug 30 12:11:54 2016 +0200
tree 8c484d9bcef61b334a5211461f1a2c473940ba60
parent 049fede21dd04e2297978788d5418b8e4a14ed88

[media] rcar-fcp: Make sure rcar_fcp_enable() returns 0 on success

When resuming from suspend-to-RAM on r8a7795/salvator-x:

    dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns 1
    PM: Device fe940000.fdp1 failed to resume noirq: error 1
    dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns 1
    PM: Device fe944000.fdp1 failed to resume noirq: error 1
    dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns 1
    PM: Device fe948000.fdp1 failed to resume noirq: error 1

According to its documentation, rcar_fcp_enable() returns 0 on success
or a negative error code if an error occurs.  Hence
fdp1_pm_runtime_resume() and vsp1_pm_runtime_resume() forward its return
value to their callers.

However, rcar_fcp_enable() forwards the return value of
pm_runtime_get_sync(), which can actually be 1 on success, leading to
the resume failure above.

To fix this, consider only negative values returned by
pm_runtime_get_sync() to be failures.

Fixes: 7b49235e83b2347c ("[media] v4l: Add Renesas R-Car FCP driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
v2:
  - Add Reviewed-by.