tag 53c1e4bf928e7b140151c3cd583f5b86ba1e6eca
tagger Ard Biesheuvel <ardb@kernel.org> Thu Nov 12 15:24:16 2020 +0100
object c2fe61d8be491ff8188edaf22e838f819999146b

Couple of EFI fixes for v5.10:
- fix memory leak in efivarfs driver
- fix HYP mode issue in 32-bit ARM version of the EFI stub when built in
  Thumb2 mode
- avoid leaking EFI pgd pages on allocation failure

commit c2fe61d8be491ff8188edaf22e838f819999146b
author Arvind Sankar <nivedita@alum.mit.edu> Tue Nov 10 11:39:19 2020 -0500
committer Ard Biesheuvel <ardb@kernel.org> Tue Nov 10 19:18:11 2020 +0100
tree 569101e67722981a5e78212c2840fabb5d4ade69
parent fe5186cf12e30facfe261e9be6c7904a170bd822

efi/x86: Free efi_pgd with free_pages()

Commit

  d9e9a6418065 ("x86/mm/pti: Allocate a separate user PGD")

changed the PGD allocation to allocate PGD_ALLOCATION_ORDER pages, so in
the error path it should be freed using free_pages() rather than
free_page().

Commit

    06ace26f4e6f ("x86/efi: Free efi_pgd with free_pages()")

fixed one instance of this, but missed another.

Move the freeing out-of-line to avoid code duplication and fix this bug.

Fixes: d9e9a6418065 ("x86/mm/pti: Allocate a separate user PGD")
Link: https://lore.kernel.org/r/20201110163919.1134431-1-nivedita@alum.mit.edu
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>