libtracefs: utest: Rename private functions to fix static building
Building trace-cmd statically fails because of duplicated symbols for
strstrip() function which is also implemented in trace-cmd. The __hidden
attribute does not resolve these conflicts for static builds due to the
lack of namespacing support in C. Refer to the associated Bugzilla page
for further details.
Although only strstrip() breaks the static build as of now, we should
fix the underlying issue comprehensively across the libtraceevent,
libtracefs, and trace-cmd packages. The recommendation is prepending
"tfs_" to private functions (tagged with __hidden attribute).
Thus:
1. If a private function starts with "trace_", then just change its
prefix to "tfs_" (e.g., trace_list_pop() to tfs_list_pop()).
2. If prepending "tfs_" prefix to a private function's name clashes with
an existing one, rename one of the functions per its context (e.g.,
rename find_tracing_dir() to tfs_find_debug_tracing_dir()).
3. Prepend "tfs_" prefix to all remaining "__hidden" functions as well
as variables.
Future __hidden functions should follow this prefixing schemed to avoid
new naming conflicts.
Also remove spaces after * in function signatures.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=217768
Link: https://lore.kernel.org/linux-trace-devel/20241030204731.69d656d8@rorschach.local.home
Cc: Douglas Raillard <douglas.raillard@arm.com>
Link: https://lore.kernel.org/20241119153221.1668158-1-metin.kaya@arm.com
Signed-off-by: Metin Kaya <metin.kaya@arm.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
21 files changed
