| From: Minghao Chi <chi.minghao@zte.com.cn> |
| Subject: fs/qnx6: delete unnecessary checks before brelse() |
| Date: Fri, 19 Aug 2022 08:18:19 +0000 |
| |
| brelse() tests whether its argument is NULL and then returns immediately. |
| Thus remove the tests which are not needed around the shown calls. |
| |
| Link: https://lkml.kernel.org/r/20220819081819.96347-1-chi.minghao@zte.com.cn |
| Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> |
| Reported-by: Zeal Robot <zealci@zte.com.cn> |
| Cc: CGEL ZTE <cgel.zte@gmail.com> |
| Cc: Matthew Wilcox <willy@infradead.org> |
| Cc: Minghao Chi <chi.minghao@zte.com.cn> |
| Cc: Muchun Song <songmuchun@bytedance.com> |
| Cc: Theodore Ts'o <tytso@mit.edu> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| fs/qnx6/inode.c | 6 ++---- |
| 1 file changed, 2 insertions(+), 4 deletions(-) |
| |
| --- a/fs/qnx6/inode.c~fs-qnx6-delete-unnecessary-checks-before-brelse |
| +++ a/fs/qnx6/inode.c |
| @@ -470,10 +470,8 @@ out2: |
| out1: |
| iput(sbi->inodes); |
| out: |
| - if (bh1) |
| - brelse(bh1); |
| - if (bh2) |
| - brelse(bh2); |
| + brelse(bh1); |
| + brelse(bh2); |
| outnobh: |
| kfree(qs); |
| s->s_fs_info = NULL; |
| _ |
