| From: Baoquan He <bhe@redhat.com> |
| Subject: mips, crash: wrap crash dumping code into crash related ifdefs |
| Date: Wed, 24 Jan 2024 13:12:51 +0800 |
| |
| Now crash codes under kernel/ folder has been split out from kexec |
| code, crash dumping can be separated from kexec reboot in config |
| items on mips with some adjustments. |
| |
| Here use IS_ENABLED(CONFIG_CRASH_RESERVE) check to decide if compiling |
| in the crashkernel reservation code. |
| |
| Link: https://lkml.kernel.org/r/20240124051254.67105-12-bhe@redhat.com |
| Signed-off-by: Baoquan He <bhe@redhat.com> |
| Cc: Al Viro <viro@zeniv.linux.org.uk> |
| Cc: Eric W. Biederman <ebiederm@xmission.com> |
| Cc: Hari Bathini <hbathini@linux.ibm.com> |
| Cc: Pingfan Liu <piliu@redhat.com> |
| Cc: Klara Modin <klarasmodin@gmail.com> |
| Cc: Michael Kelley <mhklinux@outlook.com> |
| Cc: Nathan Chancellor <nathan@kernel.org> |
| Cc: Stephen Rothwell <sfr@canb.auug.org.au> |
| Cc: Yang Li <yang.lee@linux.alibaba.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| arch/mips/kernel/setup.c | 17 ++++++----------- |
| 1 file changed, 6 insertions(+), 11 deletions(-) |
| |
| --- a/arch/mips/kernel/setup.c~mips-crash-wrap-crash-dumping-code-into-crash-related-ifdefs |
| +++ a/arch/mips/kernel/setup.c |
| @@ -442,8 +442,6 @@ static void __init mips_reserve_vmcore(v |
| #endif |
| } |
| |
| -#ifdef CONFIG_KEXEC |
| - |
| /* 64M alignment for crash kernel regions */ |
| #define CRASH_ALIGN SZ_64M |
| #define CRASH_ADDR_MAX SZ_512M |
| @@ -454,6 +452,9 @@ static void __init mips_parse_crashkerne |
| unsigned long long crash_size, crash_base; |
| int ret; |
| |
| + if (!IS_ENABLED(CONFIG_CRASH_RESERVE)) |
| + return; |
| + |
| total_mem = memblock_phys_mem_size(); |
| ret = parse_crashkernel(boot_command_line, total_mem, |
| &crash_size, &crash_base, |
| @@ -489,6 +490,9 @@ static void __init request_crashkernel(s |
| { |
| int ret; |
| |
| + if (!IS_ENABLED(CONFIG_CRASH_RESERVE)) |
| + return; |
| + |
| if (crashk_res.start == crashk_res.end) |
| return; |
| |
| @@ -498,15 +502,6 @@ static void __init request_crashkernel(s |
| (unsigned long)(resource_size(&crashk_res) >> 20), |
| (unsigned long)(crashk_res.start >> 20)); |
| } |
| -#else /* !defined(CONFIG_KEXEC) */ |
| -static void __init mips_parse_crashkernel(void) |
| -{ |
| -} |
| - |
| -static void __init request_crashkernel(struct resource *res) |
| -{ |
| -} |
| -#endif /* !defined(CONFIG_KEXEC) */ |
| |
| static void __init check_kernel_sections_mem(void) |
| { |
| _ |