| From: Liu Shixin <liushixin2@huawei.com> |
| Subject: mm/memcontrol: use kstrtobool for swapaccount param parsing |
| Date: Tue, 13 Sep 2022 15:13:58 +0800 |
| |
| Use kstrtobool which is more powerful to handle all kinds of parameters |
| like 'Yy1Nn0' or [oO][NnFf] for "on" and "off". |
| |
| Link: https://lkml.kernel.org/r/20220913071358.1812206-1-liushixin2@huawei.com |
| Signed-off-by: Liu Shixin <liushixin2@huawei.com> |
| Acked-by: Michal Hocko <mhocko@suse.com> |
| Cc: Johannes Weiner <hannes@cmpxchg.org> |
| Cc: Jonathan Corbet <corbet@lwn.net> |
| Cc: Kefeng Wang <wangkefeng.wang@huawei.com> |
| Cc: Muchun Song <songmuchun@bytedance.com> |
| Cc: Roman Gushchin <roman.gushchin@linux.dev> |
| Cc: Shakeel Butt <shakeelb@google.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| mm/memcontrol.c | 8 ++++---- |
| 1 file changed, 4 insertions(+), 4 deletions(-) |
| |
| --- a/mm/memcontrol.c~mm-memcontrol-use-kstrtobool-for-swapaccount-param-parsing |
| +++ a/mm/memcontrol.c |
| @@ -7507,10 +7507,10 @@ bool mem_cgroup_swap_full(struct folio * |
| |
| static int __init setup_swap_account(char *s) |
| { |
| - if (!strcmp(s, "1")) |
| - cgroup_memory_noswap = false; |
| - else if (!strcmp(s, "0")) |
| - cgroup_memory_noswap = true; |
| + bool res; |
| + |
| + if (!kstrtobool(s, &res)) |
| + cgroup_memory_noswap = !res; |
| return 1; |
| } |
| __setup("swapaccount=", setup_swap_account); |
| _ |
