| From: David Hildenbrand <david@redhat.com> |
| Subject: mm/migrate: remove __ClearPageMovable() |
| Date: Fri, 4 Jul 2025 12:25:08 +0200 |
| |
| Unused, let's remove it. |
| |
| The Chinese docs in Documentation/translations/zh_CN/mm/page_migration.rst |
| still mention it, but that whole docs is destined to get outdated and |
| updated by somebody that actually speaks that language. |
| |
| Link: https://lkml.kernel.org/r/20250704102524.326966-15-david@redhat.com |
| Signed-off-by: David Hildenbrand <david@redhat.com> |
| Reviewed-by: Zi Yan <ziy@nvidia.com> |
| Reviewed-by: Harry Yoo <harry.yoo@oracle.com> |
| Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> |
| Cc: Alistair Popple <apopple@nvidia.com> |
| Cc: Al Viro <viro@zeniv.linux.org.uk> |
| Cc: Arnd Bergmann <arnd@arndb.de> |
| Cc: Brendan Jackman <jackmanb@google.com> |
| Cc: Byungchul Park <byungchul@sk.com> |
| Cc: Chengming Zhou <chengming.zhou@linux.dev> |
| Cc: Christian Brauner <brauner@kernel.org> |
| Cc: Christophe Leroy <christophe.leroy@csgroup.eu> |
| Cc: Eugenio Pé rez <eperezma@redhat.com> |
| Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Cc: Gregory Price <gourry@gourry.net> |
| Cc: "Huang, Ying" <ying.huang@linux.alibaba.com> |
| Cc: Jan Kara <jack@suse.cz> |
| Cc: Jason Gunthorpe <jgg@ziepe.ca> |
| Cc: Jason Wang <jasowang@redhat.com> |
| Cc: Jerrin Shaji George <jerrin.shaji-george@broadcom.com> |
| Cc: Johannes Weiner <hannes@cmpxchg.org> |
| Cc: John Hubbard <jhubbard@nvidia.com> |
| Cc: Jonathan Corbet <corbet@lwn.net> |
| Cc: Joshua Hahn <joshua.hahnjy@gmail.com> |
| Cc: Liam Howlett <liam.howlett@oracle.com> |
| Cc: Madhavan Srinivasan <maddy@linux.ibm.com> |
| Cc: Mathew Brost <matthew.brost@intel.com> |
| Cc: Matthew Wilcox (Oracle) <willy@infradead.org> |
| Cc: Miaohe Lin <linmiaohe@huawei.com> |
| Cc: Michael Ellerman <mpe@ellerman.id.au> |
| Cc: "Michael S. Tsirkin" <mst@redhat.com> |
| Cc: Michal Hocko <mhocko@suse.com> |
| Cc: Mike Rapoport <rppt@kernel.org> |
| Cc: Minchan Kim <minchan@kernel.org> |
| Cc: Naoya Horiguchi <nao.horiguchi@gmail.com> |
| Cc: Nicholas Piggin <npiggin@gmail.com> |
| Cc: Oscar Salvador <osalvador@suse.de> |
| Cc: Peter Xu <peterx@redhat.com> |
| Cc: Qi Zheng <zhengqi.arch@bytedance.com> |
| Cc: Rakie Kim <rakie.kim@sk.com> |
| Cc: Rik van Riel <riel@surriel.com> |
| Cc: Sergey Senozhatsky <senozhatsky@chromium.org> |
| Cc: Shakeel Butt <shakeel.butt@linux.dev> |
| Cc: Suren Baghdasaryan <surenb@google.com> |
| Cc: Vlastimil Babka <vbabka@suse.cz> |
| Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com> |
| Cc: xu xin <xu.xin16@zte.com.cn> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| include/linux/migrate.h | 8 ++------ |
| mm/compaction.c | 11 ----------- |
| 2 files changed, 2 insertions(+), 17 deletions(-) |
| |
| --- a/include/linux/migrate.h~mm-migrate-remove-__clearpagemovable |
| +++ a/include/linux/migrate.h |
| @@ -35,8 +35,8 @@ struct migration_target_control; |
| * @src page. The driver should copy the contents of the |
| * @src page to the @dst page and set up the fields of @dst page. |
| * Both pages are locked. |
| - * If page migration is successful, the driver should call |
| - * __ClearPageMovable(@src) and return MIGRATEPAGE_SUCCESS. |
| + * If page migration is successful, the driver should |
| + * return MIGRATEPAGE_SUCCESS. |
| * If the driver cannot migrate the page at the moment, it can return |
| * -EAGAIN. The VM interprets this as a temporary migration failure and |
| * will retry it later. Any other error value is a permanent migration |
| @@ -106,16 +106,12 @@ static inline int migrate_huge_page_move |
| #ifdef CONFIG_COMPACTION |
| bool PageMovable(struct page *page); |
| void __SetPageMovable(struct page *page, const struct movable_operations *ops); |
| -void __ClearPageMovable(struct page *page); |
| #else |
| static inline bool PageMovable(struct page *page) { return false; } |
| static inline void __SetPageMovable(struct page *page, |
| const struct movable_operations *ops) |
| { |
| } |
| -static inline void __ClearPageMovable(struct page *page) |
| -{ |
| -} |
| #endif |
| |
| static inline |
| --- a/mm/compaction.c~mm-migrate-remove-__clearpagemovable |
| +++ a/mm/compaction.c |
| @@ -137,17 +137,6 @@ void __SetPageMovable(struct page *page, |
| } |
| EXPORT_SYMBOL(__SetPageMovable); |
| |
| -void __ClearPageMovable(struct page *page) |
| -{ |
| - VM_BUG_ON_PAGE(!PageMovable(page), page); |
| - /* |
| - * This page still has the type of a movable page, but it's |
| - * actually not movable any more. |
| - */ |
| - page->mapping = (void *)PAGE_MAPPING_MOVABLE; |
| -} |
| -EXPORT_SYMBOL(__ClearPageMovable); |
| - |
| /* Do not skip compaction more than 64 times */ |
| #define COMPACT_MAX_DEFER_SHIFT 6 |
| |
| _ |