| From: Baolin Wang <baolin.wang@linux.alibaba.com> |
| Subject: mm: shmem: remove duplicate error validation |
| Date: Fri, 7 Feb 2025 17:44:19 +0800 |
| |
| Remove duplicate error code checks for 'start' and 'end', as the |
| get_order_from_str() will only return -EINVAL if the cmdline string is |
| configured incorrectly. |
| |
| Link: https://lkml.kernel.org/r/dfadaba4c8b24c5ae1467fe8b6744b654c65ec91.1738918357.git.baolin.wang@linux.alibaba.com |
| Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> |
| Cc: David Hildenbrand <david@redhat.com> |
| Cc: Hugh Dickins <hughd@google.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| mm/shmem.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| --- a/mm/shmem.c~mm-shmem-remove-duplicate-error-validation |
| +++ a/mm/shmem.c |
| @@ -5664,19 +5664,19 @@ static int __init setup_thp_shmem(char * |
| THP_ORDERS_ALL_FILE_DEFAULT); |
| } |
| |
| - if (start == -EINVAL) { |
| + if (start < 0) { |
| pr_err("invalid size %s in thp_shmem boot parameter\n", |
| start_size); |
| goto err; |
| } |
| |
| - if (end == -EINVAL) { |
| + if (end < 0) { |
| pr_err("invalid size %s in thp_shmem boot parameter\n", |
| end_size); |
| goto err; |
| } |
| |
| - if (start < 0 || end < 0 || start > end) |
| + if (start > end) |
| goto err; |
| |
| nr = end - start + 1; |
| _ |
