| From: liujinlong <liujinlong@kylinos.cn> |
| Subject: mm: vmscan: modify an easily misunderstood function name |
| Date: Tue, 12 Sep 2023 16:59:23 +0800 |
| |
| When looking at the code in the memory part, I found that the purpose of |
| the function prepare_scan_countis very different from the function name. |
| It is easy to misunderstand when reading.The function prepare_scan_count |
| mainly completes the assignment of the scan_control structure.Therefore, I |
| suggest that the function name can be changed to prepare_scan_control, |
| which is easier to understand. |
| |
| Link: https://lkml.kernel.org/r/20230912085923.27238-1-liujinlong@kylinos.cn |
| Signed-off-by: liujinlong <liujinlong@kylinos.cn> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| mm/vmscan.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/mm/vmscan.c~mm-vmscan-modify-an-easily-misunderstood-function-name |
| +++ a/mm/vmscan.c |
| @@ -2208,7 +2208,7 @@ enum scan_balance { |
| SCAN_FILE, |
| }; |
| |
| -static void prepare_scan_count(pg_data_t *pgdat, struct scan_control *sc) |
| +static void prepare_scan_control(pg_data_t *pgdat, struct scan_control *sc) |
| { |
| unsigned long file; |
| struct lruvec *target_lruvec; |
| @@ -5834,7 +5834,7 @@ again: |
| nr_reclaimed = sc->nr_reclaimed; |
| nr_scanned = sc->nr_scanned; |
| |
| - prepare_scan_count(pgdat, sc); |
| + prepare_scan_control(pgdat, sc); |
| |
| shrink_node_memcgs(pgdat, sc); |
| |
| _ |