| From: David Hildenbrand <david@redhat.com> |
| Subject: mmc: drop nth_page() usage within SG entry |
| Date: Mon, 1 Sep 2025 17:03:50 +0200 |
| |
| It's no longer required to use nth_page() when iterating pages within a |
| single SG entry, so let's drop the nth_page() usage. |
| |
| Link: https://lkml.kernel.org/r/20250901150359.867252-30-david@redhat.com |
| Signed-off-by: David Hildenbrand <david@redhat.com> |
| Acked-by: Ulf Hansson <ulf.hansson@linaro.org> |
| Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> |
| Cc: Alex Dubov <oakad@yahoo.com> |
| Cc: Jesper Nilsson <jesper.nilsson@axis.com> |
| Cc: Lars Persson <lars.persson@axis.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| drivers/mmc/host/tifm_sd.c | 4 ++-- |
| drivers/mmc/host/usdhi6rol0.c | 4 ++-- |
| 2 files changed, 4 insertions(+), 4 deletions(-) |
| |
| --- a/drivers/mmc/host/tifm_sd.c~mmc-drop-nth_page-usage-within-sg-entry |
| +++ a/drivers/mmc/host/tifm_sd.c |
| @@ -191,7 +191,7 @@ static void tifm_sd_transfer_data(struct |
| } |
| off = sg[host->sg_pos].offset + host->block_pos; |
| |
| - pg = nth_page(sg_page(&sg[host->sg_pos]), off >> PAGE_SHIFT); |
| + pg = sg_page(&sg[host->sg_pos]) + (off >> PAGE_SHIFT); |
| p_off = offset_in_page(off); |
| p_cnt = PAGE_SIZE - p_off; |
| p_cnt = min(p_cnt, cnt); |
| @@ -240,7 +240,7 @@ static void tifm_sd_bounce_block(struct |
| } |
| off = sg[host->sg_pos].offset + host->block_pos; |
| |
| - pg = nth_page(sg_page(&sg[host->sg_pos]), off >> PAGE_SHIFT); |
| + pg = sg_page(&sg[host->sg_pos]) + (off >> PAGE_SHIFT); |
| p_off = offset_in_page(off); |
| p_cnt = PAGE_SIZE - p_off; |
| p_cnt = min(p_cnt, cnt); |
| --- a/drivers/mmc/host/usdhi6rol0.c~mmc-drop-nth_page-usage-within-sg-entry |
| +++ a/drivers/mmc/host/usdhi6rol0.c |
| @@ -323,7 +323,7 @@ static void usdhi6_blk_bounce(struct usd |
| |
| host->head_pg.page = host->pg.page; |
| host->head_pg.mapped = host->pg.mapped; |
| - host->pg.page = nth_page(host->pg.page, 1); |
| + host->pg.page = host->pg.page + 1; |
| host->pg.mapped = kmap(host->pg.page); |
| |
| host->blk_page = host->bounce_buf; |
| @@ -503,7 +503,7 @@ static void usdhi6_sg_advance(struct usd |
| /* We cannot get here after crossing a page border */ |
| |
| /* Next page in the same SG */ |
| - host->pg.page = nth_page(sg_page(host->sg), host->page_idx); |
| + host->pg.page = sg_page(host->sg) + host->page_idx; |
| host->pg.mapped = kmap(host->pg.page); |
| host->blk_page = host->pg.mapped; |
| |
| _ |