| From: Arnd Bergmann <arnd@arndb.de> |
| Subject: nilfs2: fix out-of-range warning |
| Date: Thu, 28 Mar 2024 15:30:44 +0100 |
| |
| clang-14 points out that v_size is always smaller than a 64KB page size if |
| that is configured by the CPU architecture: |
| |
| fs/nilfs2/ioctl.c:63:19: error: result of comparison of constant 65536 with expression of type '__u16' (aka 'unsigned short') is always false [-Werror,-Wtautological-constant-out-of-range-compare] |
| if (argv->v_size > PAGE_SIZE) |
| ~~~~~~~~~~~~ ^ ~~~~~~~~~ |
| |
| This is ok, so just shut up that warning with a cast. |
| |
| Link: https://lkml.kernel.org/r/20240328143051.1069575-7-arnd@kernel.org |
| Fixes: 3358b4aaa84f ("nilfs2: fix problems of memory allocation in ioctl") |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Reviewed-by: Justin Stitt <justinstitt@google.com> |
| Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> |
| Cc: Bill Wendling <morbo@google.com> |
| Cc: Christian Brauner <brauner@kernel.org> |
| Cc: Jeff Layton <jlayton@kernel.org> |
| Cc: Nathan Chancellor <nathan@kernel.org> |
| Cc: Nick Desaulniers <ndesaulniers@google.com> |
| Cc: Philipp Stanner <pstanner@redhat.com> |
| Cc: Thorsten Blum <thorsten.blum@toblux.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| fs/nilfs2/ioctl.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/nilfs2/ioctl.c~nilfs2-fix-out-of-range-warning |
| +++ a/fs/nilfs2/ioctl.c |
| @@ -60,7 +60,7 @@ static int nilfs_ioctl_wrap_copy(struct |
| if (argv->v_nmembs == 0) |
| return 0; |
| |
| - if (argv->v_size > PAGE_SIZE) |
| + if ((size_t)argv->v_size > PAGE_SIZE) |
| return -EINVAL; |
| |
| /* |
| _ |
