| From: Kees Cook <keescook@chromium.org> |
| Date: Fri, 11 May 2018 18:24:12 +1000 |
| Subject: video: uvesafb: Fix integer overflow in allocation |
| |
| commit 9f645bcc566a1e9f921bdae7528a01ced5bc3713 upstream. |
| |
| cmap->len can get close to INT_MAX/2, allowing for an integer overflow in |
| allocation. This uses kmalloc_array() instead to catch the condition. |
| |
| Reported-by: Dr Silvio Cesare of InfoSect <silvio.cesare@gmail.com> |
| Fixes: 8bdb3a2d7df48 ("uvesafb: the driver core") |
| Signed-off-by: Kees Cook <keescook@chromium.org> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/video/fbdev/uvesafb.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/video/fbdev/uvesafb.c |
| +++ b/drivers/video/fbdev/uvesafb.c |
| @@ -1059,7 +1059,8 @@ static int uvesafb_setcmap(struct fb_cma |
| info->cmap.len || cmap->start < info->cmap.start) |
| return -EINVAL; |
| |
| - entries = kmalloc(sizeof(*entries) * cmap->len, GFP_KERNEL); |
| + entries = kmalloc_array(cmap->len, sizeof(*entries), |
| + GFP_KERNEL); |
| if (!entries) |
| return -ENOMEM; |
| |
