| From: Johan Hovold <johan@kernel.org> |
| Date: Thu, 16 Mar 2017 11:41:55 -0700 |
| Subject: Input: kbtab - validate number of endpoints before using them |
| |
| commit cb1b494663e037253337623bf1ef2df727883cb7 upstream. |
| |
| Make sure to check the number of endpoints to avoid dereferencing a |
| NULL-pointer should a malicious device lack endpoints. |
| |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/input/tablet/kbtab.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| --- a/drivers/input/tablet/kbtab.c |
| +++ b/drivers/input/tablet/kbtab.c |
| @@ -117,6 +117,9 @@ static int kbtab_probe(struct usb_interf |
| struct input_dev *input_dev; |
| int error = -ENOMEM; |
| |
| + if (intf->cur_altsetting->desc.bNumEndpoints < 1) |
| + return -ENODEV; |
| + |
| kbtab = kzalloc(sizeof(struct kbtab), GFP_KERNEL); |
| input_dev = input_allocate_device(); |
| if (!kbtab || !input_dev) |
