| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Tue, 3 Dec 2019 12:58:55 +0300 |
| Subject: brcmfmac: Fix use after free in brcmf_sdio_readframes() |
| |
| commit 216b44000ada87a63891a8214c347e05a4aea8fe upstream. |
| |
| The brcmu_pkt_buf_free_skb() function frees "pkt" so it leads to a |
| static checker warning: |
| |
| drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:1974 brcmf_sdio_readframes() |
| error: dereferencing freed memory 'pkt' |
| |
| It looks like there was supposed to be a continue after we free "pkt". |
| |
| Fixes: 4754fceeb9a6 ("brcmfmac: streamline SDIO read frame routine") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Acked-by: Franky Lin <franky.lin@broadcom.com> |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| [bwh: Backported to 3.16: adjust filename] |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c |
| +++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c |
| @@ -1972,6 +1972,7 @@ static uint brcmf_sdio_readframes(struct |
| BRCMF_SDIO_FT_NORMAL)) { |
| rd->len = 0; |
| brcmu_pkt_buf_free_skb(pkt); |
| + continue; |
| } |
| bus->sdcnt.rx_readahead_cnt++; |
| if (rd->len != roundup(rd_new.len, 16)) { |
