| From: Wei Yongjun <weiyj.lk@gmail.com> |
| Date: Mon, 8 Aug 2016 14:09:27 +0000 |
| Subject: dm flakey: return -EINVAL on interval bounds error in flakey_ctr() |
| |
| commit bff7e067ee518f9ed7e1cbc63e4c9e01670d0b71 upstream. |
| |
| Fix to return error code -EINVAL instead of 0, as is done elsewhere in |
| this function. |
| |
| Fixes: e80d1c805a3b ("dm: do not override error code returned from dm_get_device()") |
| Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com> |
| Signed-off-by: Mike Snitzer <snitzer@redhat.com> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/md/dm-flakey.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/drivers/md/dm-flakey.c |
| +++ b/drivers/md/dm-flakey.c |
| @@ -200,11 +200,13 @@ static int flakey_ctr(struct dm_target * |
| |
| if (!(fc->up_interval + fc->down_interval)) { |
| ti->error = "Total (up + down) interval is zero"; |
| + r = -EINVAL; |
| goto bad; |
| } |
| |
| if (fc->up_interval + fc->down_interval < fc->up_interval) { |
| ti->error = "Interval overflow"; |
| + r = -EINVAL; |
| goto bad; |
| } |
| |