vhost-vdpa: fix use after free in vhost_vdpa_probe()
mainline inclusion
from mainline-v6.7-rc2
commit e07754e0a1ea2d63fb29574253d1fd7405607343
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9RFM2
CVE: CVE-2023-52795
Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=e07754e0a1ea2d63fb29574253d1fd7405607343
--------------------------------
The put_device() calls vhost_vdpa_release_dev() which calls
ida_simple_remove() and frees "v". So this call to
ida_simple_remove() is a use after free and a double free.
Fixes: ebe6a354fa7e ("vhost-vdpa: Call ida_simple_remove() when failed")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Message-Id: <cf53cb61-0699-4e36-a980-94fd4268ff00@moroto.mountain>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Wei Li <liwei391@huawei.com>
(cherry picked from commit fde0ab16ad111747d3ea58998b576b85e1a1d1dd)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index eed51d00..9a191ca 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -1702,7 +1702,6 @@ static int vhost_vdpa_probe(struct vdpa_device *vdpa)
err:
put_device(&v->dev);
- ida_simple_remove(&vhost_vdpa_ida, v->minor);
return r;
}
