tree 6f22dd7a542bc6646b5109009c3fbab8634bc2e1
parent c1e82f5ccb40e71297a3a312b94d2600bcc6cf7b
author Darrick J. Wong <darrick.wong@oracle.com> 1567205384 -0700
committer Darrick J. Wong <darrick.wong@oracle.com> 1567643491 -0700

xfs_repair: add AG btree rmaps into the filesystem after syncing sb

In rmap_store_ag_btree_rec(), we try to reserve 16 blocks to handle
adding all the AG btree rmaps to the rmap record.  Unfortunately, at
that point in phase5 we haven't yet reinitialied sb_fdblocks, so
reserving blocks can fail if repair reconstructed the primary sb from a
secondary sb.  Even if the function succeeds, this still leads to
incorrect fdblocks because phase 5 resets sb_fdblocks after running the
rmap transactions.

To avoid all this, move the rmap_store_ag_btree_rec call to after the sb
has been reset.  xfs/350 was helpful in finding cases where xfs_repair
errored out while repairing the filesystem.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>