NFS: Fix a typo in include/linux/nfs_fs.h nfs_commit_inode() needs to be defined irrespectively of whether or not we are supporting NFSv3 and NFSv4. Allow the compiler to optimise away code in the NFSv2-only case by converting it into an inlined stub function. Reported-and-tested-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
diff --git a/fs/nfs/write.c b/fs/nfs/write.c index bb72ad3..9f81bdd 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c
@@ -1454,11 +1454,6 @@ return ret; } #else -int nfs_commit_inode(struct inode *inode, int how) -{ - return 0; -} - static int nfs_commit_unstable_pages(struct inode *inode, struct writeback_control *wbc) { return 0;
diff --git a/include/linux/nfs_fs.h b/include/linux/nfs_fs.h index f6e2455..bad4d12 100644 --- a/include/linux/nfs_fs.h +++ b/include/linux/nfs_fs.h
@@ -496,6 +496,12 @@ extern int nfs_commit_inode(struct inode *, int); extern struct nfs_write_data *nfs_commitdata_alloc(void); extern void nfs_commit_free(struct nfs_write_data *wdata); +#else +static inline int +nfs_commit_inode(struct inode *inode, int how) +{ + return 0; +} #endif static inline int