proc: Kill dead code in proc_fill_cache

Remove the questionable and redundant negative dentry handling.
(instantiate)() will return an error value, NULL with the new dentry
updated to point at an inode, or a freshly allocated dentry from
somewhere else.  (instantiate)() will never return a negative dentry,
because proc never generates negative dentries.

Remove the useless call to find_ino_number it was a hail marry attempt
to find something and as Al Viro rightly pointed out the directory
inode mutex is held during both lookup and readdir so it is not
possible for the dcache to change outside of proc_fill_cache.

Default the inode number to PROC_ROOT_INO instead of 0 to avoid having
to test for failure of finding a better inode number.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
1 file changed