xfsprogs: LDFLAGS comes from configure, not environment
$ LDFLAGS=foo make
bad things happen because we don't initialise LDFLAGS to an empty
string in include/builddefs.in and hence make takes wahtever is in
the environment and runs with it. This causes problems with linker
options specified correctly through configure.
We don't support overriding build flags (like CFLAGS) though the
make environment, so it was an oversight 13 years ago to allow
LDFLAGS to be overridden when adding support to custom LDFLAGS being
passed from the the configure script. This ensures we only ever use
linker flags from configure, not the make environment.
Signed-off-by: Dave Chinner <firstname.lastname@example.org>
Reviewed-by: Christoph Hellwig <email@example.com>
Signed-off-by: Eric Sandeen <firstname.lastname@example.org>
diff --git a/include/builddefs.in b/include/builddefs.in
index 891bf93..6ed9d29 100644
@@ -16,6 +16,10 @@
CFLAGS = @CFLAGS@ -D_FILE_OFFSET_BITS=64 -Wno-address-of-packed-member
BUILD_CFLAGS = @BUILD_CFLAGS@ -D_FILE_OFFSET_BITS=64
+# make sure we don't pick up whacky LDFLAGS from the make environment and
+# only use what we calculate from the configured options above.
LIBRT = @librt@
LIBUUID = @libuuid@
LIBPTHREAD = @libpthread@