| From e8fda16939fc9f87ad0832a942d1e521022c6f97 Mon Sep 17 00:00:00 2001 |
| From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Date: Tue, 29 May 2018 17:31:06 +0200 |
| Subject: [PATCH 1269/1795] USB: gadget: udc: renesas_usb3: no need to check |
| return value of debugfs_create functions |
| |
| When calling debugfs functions, there is no need to ever check the |
| return value. The function can work or not, but the code logic should |
| never do something different based on this. |
| |
| Cc: Felipe Balbi <balbi@kernel.org> |
| Cc: Simon Horman <horms+renesas@verge.net.au> |
| Cc: Geert Uytterhoeven <geert+renesas@glider.be> |
| Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| (cherry picked from commit 743d1effe6c1c6b2b42e9e4ca958a4403373702d) |
| Signed-off-by: Simon Horman <horms+renesas@verge.net.au> |
| Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> |
| --- |
| drivers/usb/gadget/udc/renesas_usb3.c | 18 +++--------------- |
| 1 file changed, 3 insertions(+), 15 deletions(-) |
| |
| diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c |
| index 4df8bf7ccfe9..c7335fe97022 100644 |
| --- a/drivers/usb/gadget/udc/renesas_usb3.c |
| +++ b/drivers/usb/gadget/udc/renesas_usb3.c |
| @@ -2394,22 +2394,10 @@ static const struct file_operations renesas_usb3_b_device_fops = { |
| static void renesas_usb3_debugfs_init(struct renesas_usb3 *usb3, |
| struct device *dev) |
| { |
| - struct dentry *root, *file; |
| + usb3->dentry = debugfs_create_dir(dev_name(dev), NULL); |
| |
| - root = debugfs_create_dir(dev_name(dev), NULL); |
| - if (IS_ERR_OR_NULL(root)) { |
| - dev_info(dev, "%s: Can't create the root\n", __func__); |
| - return; |
| - } |
| - |
| - file = debugfs_create_file("b_device", 0644, root, usb3, |
| - &renesas_usb3_b_device_fops); |
| - if (!file) { |
| - dev_info(dev, "%s: Can't create debugfs mode\n", __func__); |
| - debugfs_remove_recursive(root); |
| - } else { |
| - usb3->dentry = root; |
| - } |
| + debugfs_create_file("b_device", 0644, usb3->dentry, usb3, |
| + &renesas_usb3_b_device_fops); |
| } |
| |
| /*------- platform_driver ------------------------------------------------*/ |
| -- |
| 2.19.0 |
| |
