| From 9d07decc482d8e2e0b15f789e8b4846756ae4a45 Mon Sep 17 00:00:00 2001 |
| From: "Rafael J. Wysocki" <rjw@sisk.pl> |
| Date: Mon, 21 Nov 2011 23:33:55 +0100 |
| Subject: PM / Sleep: Simplify device_suspend_noirq() |
| |
| Remove a few if () and return statements in device_suspend_noirq() |
| that aren't really necessary. |
| |
| Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> |
| Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> |
| (cherry picked from commit 64e94aafb6a5c4f419e9b8f93950914b5ac162a9) |
| |
| Signed-off-by: Simon Horman <horms@verge.net.au> |
| --- |
| drivers/base/power/main.c | 12 ++---------- |
| 1 file changed, 2 insertions(+), 10 deletions(-) |
| |
| diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c |
| index 1172aea..406f82c 100644 |
| --- a/drivers/base/power/main.c |
| +++ b/drivers/base/power/main.c |
| @@ -763,31 +763,23 @@ static pm_message_t resume_event(pm_message_t sleep_state) |
| */ |
| static int device_suspend_noirq(struct device *dev, pm_message_t state) |
| { |
| - int error; |
| + int error = 0; |
| |
| if (dev->pm_domain) { |
| pm_dev_dbg(dev, state, "LATE power domain "); |
| error = pm_noirq_op(dev, &dev->pm_domain->ops, state); |
| - if (error) |
| - return error; |
| } else if (dev->type && dev->type->pm) { |
| pm_dev_dbg(dev, state, "LATE type "); |
| error = pm_noirq_op(dev, dev->type->pm, state); |
| - if (error) |
| - return error; |
| } else if (dev->class && dev->class->pm) { |
| pm_dev_dbg(dev, state, "LATE class "); |
| error = pm_noirq_op(dev, dev->class->pm, state); |
| - if (error) |
| - return error; |
| } else if (dev->bus && dev->bus->pm) { |
| pm_dev_dbg(dev, state, "LATE "); |
| error = pm_noirq_op(dev, dev->bus->pm, state); |
| - if (error) |
| - return error; |
| } |
| |
| - return 0; |
| + return error; |
| } |
| |
| /** |
| -- |
| 1.7.10.1.362.g242cab3 |
| |