| From 9ef47f4fa90319e6b33d0ead11ec4e7da4ad8998 Mon Sep 17 00:00:00 2001 |
| From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
| Date: Sun, 31 Dec 2017 21:41:36 +0300 |
| Subject: [PATCH 0476/1795] sh_eth: kill redundant check in the probe() method |
| |
| Browsing thru the driver disassembly, I noticed that gcc was able to |
| figure out that the 'ndev' pointer is always non-NULL when calling |
| free_netdev() on the probe() method's error path and thus skip that |
| redundant NULL check... gcc is smart, be like gcc! :-) |
| |
| Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
| Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| (cherry picked from commit 4282fc47c01262fdda55a9d63a4e25173fd9afb4) |
| Signed-off-by: Simon Horman <horms+renesas@verge.net.au> |
| Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> |
| --- |
| drivers/net/ethernet/renesas/sh_eth.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c |
| index 007f54b5766b..d7216bcace03 100644 |
| --- a/drivers/net/ethernet/renesas/sh_eth.c |
| +++ b/drivers/net/ethernet/renesas/sh_eth.c |
| @@ -3278,8 +3278,7 @@ static int sh_eth_drv_probe(struct platform_device *pdev) |
| |
| out_release: |
| /* net_dev free */ |
| - if (ndev) |
| - free_netdev(ndev); |
| + free_netdev(ndev); |
| |
| pm_runtime_put(&pdev->dev); |
| pm_runtime_disable(&pdev->dev); |
| -- |
| 2.19.0 |
| |
