| From ffdde5932042600c6807d46c1550b28b0db6a3bc Mon Sep 17 00:00:00 2001 |
| From: Navid Emamdoost <navid.emamdoost@gmail.com> |
| Date: Fri, 4 Oct 2019 14:29:16 -0500 |
| Subject: crypto: user - fix memory leak in crypto_report |
| |
| From: Navid Emamdoost <navid.emamdoost@gmail.com> |
| |
| commit ffdde5932042600c6807d46c1550b28b0db6a3bc upstream. |
| |
| In crypto_report, a new skb is created via nlmsg_new(). This skb should |
| be released if crypto_report_alg() fails. |
| |
| Fixes: a38f7907b926 ("crypto: Add userspace configuration API") |
| Cc: <stable@vger.kernel.org> |
| Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| crypto/crypto_user.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/crypto/crypto_user.c |
| +++ b/crypto/crypto_user.c |
| @@ -221,8 +221,10 @@ static int crypto_report(struct sk_buff |
| info.nlmsg_flags = 0; |
| |
| err = crypto_report_alg(alg, &info); |
| - if (err) |
| + if (err) { |
| + kfree_skb(skb); |
| return err; |
| + } |
| |
| return nlmsg_unicast(crypto_nlsk, skb, NETLINK_CB(in_skb).portid); |
| } |