| From 3c11c4bed02b202e278c0f5c319ae435d7fb9815 Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <johan@kernel.org> |
| Date: Tue, 10 Dec 2019 12:25:59 +0100 |
| Subject: USB: adutux: fix interface sanity check |
| |
| From: Johan Hovold <johan@kernel.org> |
| |
| commit 3c11c4bed02b202e278c0f5c319ae435d7fb9815 upstream. |
| |
| Make sure to use the current alternate setting when verifying the |
| interface descriptors to avoid binding to an invalid interface. |
| |
| Failing to do so could cause the driver to misbehave or trigger a WARN() |
| in usb_submit_urb() that kernels with panic_on_warn set would choke on. |
| |
| Fixes: 03270634e242 ("USB: Add ADU support for Ontrak ADU devices") |
| Cc: stable <stable@vger.kernel.org> # 2.6.19 |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Link: https://lore.kernel.org/r/20191210112601.3561-3-johan@kernel.org |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/misc/adutux.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/usb/misc/adutux.c |
| +++ b/drivers/usb/misc/adutux.c |
| @@ -686,7 +686,7 @@ static int adu_probe(struct usb_interfac |
| init_waitqueue_head(&dev->read_wait); |
| init_waitqueue_head(&dev->write_wait); |
| |
| - iface_desc = &interface->altsetting[0]; |
| + iface_desc = &interface->cur_altsetting[0]; |
| |
| /* set up the endpoint information */ |
| for (i = 0; i < iface_desc->desc.bNumEndpoints; ++i) { |
