[BUGFIX] iwlwifi: mvm: rs: fix success ratio comparison in rs_get_best_rate

success_ratio is actually 128 * SR in percentage while
IWL_MVM_RS_SR_NO_DECREASE is 85%. Fix this by using RS_PERCENT().
This bug caused the if branch to be always executed. This in turn
led to always selecting a rate, following a column switch, in which
the expected throughput would exceed the best expected current throughput.
In some scenarios where the success ratio isn't >85% such a rate
could be too aggressive leading us to avoid the new column.
This has the potential of causing sub optimal performance.


Change-Id: Ic8bfd2ddd9909957a2dd1d9881010a71b4ffb34b
Reported-by: Moshe Harel <moshe.harel@intel.com>
Signed-off-by: Eyal Shapira <eyalx.shapira@intel.com>
Reviewed-on: https://git-amr-3.devtools.intel.com/gerrit/3931
Tested-by: ec ger unix iil jenkins <EC.GER.UNIX.IIL.JENKINS@INTEL.COM>
Reviewed-by: Berg, Johannes <johannes.berg@intel.com>
Reviewed-on: https://git-amr-3.devtools.intel.com/gerrit/4733
x-iwlwifi-stack-dev: a44fa2ae94a8d2fa3de82d02618c0ea5ba2f09d9
2 files changed