f2fs-tools: fix typo of HAVE_PREAD macro and remove duplicate semicolons
1. Fix typo in HAVE_PREAD macro check (lib/libf2fs_io.c:403):
- Change HAVE_RPEAD -> HAVE_PREAD
- The misspelled macro caused pread() optimization to never be used,
forcing the code to always use the slower lseek() + read() path
instead of the atomic pread() call.
2. Remove duplicate semicolons:
- mkfs/f2fs_format.c:211: Remove extra semicolon in hot_ext_count assignment
- fsck/dump.c:119: Remove extra semicolon in free_segs initialization
These are minor code quality fixes that don't change functionality but
improve code correctness and enable the pread() optimization.
Fixes: 4b7e95300988 ("f2fs-tools: use pread and pwrite when they are available.")
Signed-off-by: Xiaole He <hexiaole1994@126.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
diff --git a/fsck/dump.c b/fsck/dump.c
index 21de2ac..f5c95de 100644
--- a/fsck/dump.c
+++ b/fsck/dump.c
@@ -116,7 +116,7 @@
struct sit_info *sit_i = SIT_I(sbi);
unsigned int segno;
char buf[BUF_SZ];
- u32 free_segs = 0;;
+ u32 free_segs = 0;
u64 valid_blocks = 0;
int ret;
int fd, i;
diff --git a/lib/libf2fs_io.c b/lib/libf2fs_io.c
index 919318e..deafc4f 100644
--- a/lib/libf2fs_io.c
+++ b/lib/libf2fs_io.c
@@ -400,7 +400,7 @@
{
if (c.sparse_mode)
return 0;
-#ifdef HAVE_RPEAD
+#ifdef HAVE_PREAD
if (pread(c.kd, buf, len, (off_t)offset) < 0)
return -1;
#else
diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
index 6efad45..27413ce 100644
--- a/mkfs/f2fs_format.c
+++ b/mkfs/f2fs_format.c
@@ -208,7 +208,7 @@
if (i == 0)
set_sb(extension_count, pos);
else
- sb->hot_ext_count = pos - get_sb(extension_count);;
+ sb->hot_ext_count = pos - get_sb(extension_count);
if (!ext_str)
continue;
