)]}'
{
  "commit": "4b20e103a63d056fb7a594b23d42ef8e0dbfc5ff",
  "tree": "ccf6f187f87caceeda477abc1df6b6c2fb66b9f6",
  "parents": [
    "97bebbcd8b9368212e08913461bb511e35b46627"
  ],
  "author": {
    "name": "Masahiro Yamada",
    "email": "masahiroy@kernel.org",
    "time": "Sat Aug 01 16:08:49 2020 +0900"
  },
  "committer": {
    "name": "Masahiro Yamada",
    "email": "masahiroy@kernel.org",
    "time": "Sat Aug 01 20:54:39 2020 +0900"
  },
  "message": "Revert \"kconfig: qconf: don\u0027t show goback button on splitMode\"\n\nThis reverts commit cc1c08edccaf5317d99a17a3231fe06381044e83.\n\nMaxim Levitsky reports \u0027make xconfig\u0027 crashes since that commit\n(https://lkml.org/lkml/2020/7/18/411)\n\nOr, the following is simple test code that makes it crash:\n\n    menu \"Menu\"\n\n    config FOO\n            bool \"foo\"\n            default y\n\n    menuconfig BAR\n            bool \"bar\"\n            depends on FOO\n\n    endmenu\n\nSelect the Split View mode, and double-click \"bar\" in the right\nwindow, then you will see Segmentation fault.\n\nWhen \u0027last\u0027 is not set for symbolMode, the following code in\nConfigList::updateList() calls firstChild().\n\n  item \u003d last ? last-\u003enextSibling() : firstChild();\n\nHowever, the pointer returned by ConfigList::firstChild() does not\nseem to be compatible with (ConfigItem *), which seems another bug.\n\nI\u0027d rather want to reconsider whether hiding the goback icon is the\nright thing to do.\n\nIn the following test code, the Split View shows \"Menu2\" and \"Menu3\"\nin the right window. You can descend into \"Menu3\", but there is no way\nto ascend back to \"Menu2\" from \"Menu3\".\n\n    menu \"Menu1\"\n\n    config FOO\n            bool \"foo\"\n            default y\n\n    menu \"Menu2\"\n            depends on FOO\n\n    menu \"Menu3\"\n\n    config BAZ\n            bool \"baz\"\n\n    endmenu\n\n    endmenu\n\n    endmenu\n\nIt is true that the goback button is currently not functional due to\nyet another bug, but hiding the problem is not the right way to go.\n\nAnyway, Segmentation fault is fatal. Revert the offending commit for\nnow, and we should find the right solution.\n\nReported-by:  Maxim Levitsky \u003cmlevitsk@redhat.com\u003e\nSigned-off-by: Masahiro Yamada \u003cmasahiroy@kernel.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "86bc8ded8de8ce9f14dc4724ae55bce208f62bb3",
      "old_mode": 33188,
      "old_path": "scripts/kconfig/qconf.cc",
      "new_id": "762e2ac6679e10b7124a7062f7fee1a7d3b5bb53",
      "new_mode": 33188,
      "new_path": "scripts/kconfig/qconf.cc"
    }
  ]
}