Tag summary

+ Features
  - Replace zero-length array with flexible-array
  - add a valid state flags check
  - add consistency check between state and dfa diff encode flags
  - add apparmor subdir to proc attr interface
  - fail unpack if profile mode is unknown
  - add outofband transition and use it in xattr match
  - ensure that dfa state tables have entries

+ Cleanups
  - Use true and false for bool variable
  - Remove semicolon
  - Clean code by removing redundant instructions
  - Replace two seq_printf() calls by seq_puts() in aa_label_seq_xprint()
  - remove duplicate check of xattrs on profile attachment
  - remove useless aafs_create_symlink

+ Bug fixes
  - Fix memory leak of profile proxy
  - fix introspection of of task mode for unconfined tasks
  - fix nnp subset test for unconfined
  - check/put label on apparmor_sk_clone_security()
apparmor: Fix memory leak of profile proxy

When the proxy isn't replaced and the profile is removed, the proxy
is being leaked resulting in a kmemleak check message of

unreferenced object 0xffff888077a3a490 (size 16):
  comm "apparmor_parser", pid 128041, jiffies 4322684109 (age 1097.028s)
  hex dump (first 16 bytes):
    03 00 00 00 00 00 00 00 b0 92 fd 4b 81 88 ff ff  ...........K....
  backtrace:
    [<0000000084d5daf2>] aa_alloc_proxy+0x58/0xe0
    [<00000000ecc0e21a>] aa_alloc_profile+0x159/0x1a0
    [<000000004cc9ce15>] unpack_profile+0x275/0x1c40
    [<000000007332b3ca>] aa_unpack+0x1e7/0x7e0
    [<00000000e25e31bd>] aa_replace_profiles+0x18a/0x1d10
    [<00000000350d9415>] policy_update+0x237/0x650
    [<000000003fbf934e>] profile_load+0x122/0x160
    [<0000000047f7b781>] vfs_write+0x139/0x290
    [<000000008ad12358>] ksys_write+0xcd/0x170
    [<000000001a9daa7b>] do_syscall_64+0x70/0x310
    [<00000000b9efb0cf>] entry_SYSCALL_64_after_hwframe+0x49/0xb3

Make sure to cleanup the profile's embedded label which will result
on the proxy being properly freed.

Fixes: 637f688dc3dc ("apparmor: switch from profiles to using labels on contexts")
Signed-off-by: John Johansen <john.johansen@canonical.com>
3 files changed