)]}'
{
  "commit": "50dba8189b1f628073eb61d824ae8a8a1b43cefb",
  "tree": "8591b11cee592bb302fb36b6d6a217fbb83ab344",
  "parents": [
    "91c1d0836aa4a228e76c0b8c5d83903f1f6bfdbb"
  ],
  "author": {
    "name": "Darrick J. Wong",
    "email": "djwong@kernel.org",
    "time": "Wed Jul 13 20:58:28 2022 -0500"
  },
  "committer": {
    "name": "Eric Sandeen",
    "email": "sandeen@sandeen.net",
    "time": "Wed Jul 13 20:58:28 2022 -0500"
  },
  "message": "mkfs: terminate getsubopt arrays properly\n\nHaving not drank any (or maybe too much) coffee this morning, I typed:\n\n$ mkfs.xfs -d agcount\u003d3 -d nrext64\u003d0\nSegmentation fault\n\nI traced this down to getsubopt walking off the end of the dopts.subopts\narray.  The manpage says you\u0027re supposed to terminate the suboptions\nstring array with a NULL entry, but the structure definition uses\nMAX_SUBOPTS/D_MAX_OPTS directly, which means there is no terminator.\n\nExplicitly terminate each suboption array with a NULL entry after\nmaking room for it.\n\nSigned-off-by: Darrick J. Wong \u003cdjwong@kernel.org\u003e\n[sandeen: explicitly add NULL terminators \u0026 clarify comment]\nReviewed-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "db322b3aa335971c6379fe2127803a4be11d6383",
      "old_mode": 33188,
      "old_path": "mkfs/xfs_mkfs.c",
      "new_id": "b140b8153530c239fc21ca8ee925fde687c32c86",
      "new_mode": 33188,
      "new_path": "mkfs/xfs_mkfs.c"
    }
  ]
}