misc fixes

 - Remove SUBDIRS variable on top-level Makefile.am; using
   SUBDIRS=. is only meaningful to ask automake an explicit ordering of the
   sub-directory processing.

 - Add $(AM_LDFLAGS) to the library's LDFLAGS; this is important because
   one of the most common mistake is forgetting that the variable is an
   override.

 - check_PROGRAMS only build the programs, but doesn't run them; TESTS run
   the command; this way it is possible to execute a script, but build a
   binary that the script uses.

 - Pass CFLAGS in ./configure command line when using ./autogen.sh.

 - Use M4sh syntax instead of sh syntax for conditionals (AS_IF rather than
   if); when you don't use M4sh, AC_REQUIRE does not behave correctly,
   leading to a common mistake when using PKG_CHECK_MODULES.

 - Add [default=(enabled|disabled)] comments in options description; this
   makes them behave a lot more like autoconf's own descriptions.

 - Correct a warning in libabc.c (return with no value in function
   returning non-void).

 - Fix path mistakes in pkg-config data file.

Signed-off-by: Diego Elio Pettenò <flameeyes@flameeyes.eu>
5 files changed