- Deprecate pci_get_bus_and_slot(); apple_bl
- Bug Fixes
- Enable Chip Select when conducting SPI transfers; corgi_lcd, tdo24m, tosa_lcd
-----BEGIN PGP SIGNATURE-----
-----END PGP SIGNATURE-----
backlight: tdo24m: Fix the SPI CS between transfers
Currently the LCD display (TD035S) on the cm-x300 platform is broken and
The TD0245S specification requires that the chipselect is toggled
between commands sent to the panel. This was also the purpose of the
former patch of commit f64dcac0b124 ("backlight: tdo24m: ensure chip
select changes between transfers").
Unfortunately, the "cs_change" field of a SPI transfer is
misleading. Its true meaning is that for a SPI message holding multiple
transfers, the chip select is toggled between each transfer, but for the
last transfer it remains asserted.
In this driver, all the SPI messages contain exactly one transfer, which
means that each transfer is the last of its message, and as a
consequence the chip select is never toggled.
Actually, there was a second bug hidding the first one, hence the
problem was not seen until v4.6. This problem was fixed by commit
a52db659c79c ("spi: pxa2xx: Fix cs_change management") for PXA based
This fix makes the TD035S work again on a cm-x300 board. The same
applies to other PXA boards, ie. corgi and tosa.
Fixes: a52db659c79c ("spi: pxa2xx: Fix cs_change management")
Reported-by: Andrea Adami <email@example.com>
Signed-off-by: Robert Jarzmik <firstname.lastname@example.org>
Acked-by: Daniel Thompson <email@example.com>
Signed-off-by: Lee Jones <firstname.lastname@example.org>
3 files changed