| tag | f8aa26662a4ba547f7aba208840998b5cb8153b9 | |
|---|---|---|
| tagger | Lee Jones <lee@kernel.org> | Thu Nov 30 13:51:09 2023 +0000 |
| object | 8f2244c9af245ff72185c0473827125ee6b2d1a5 |
- Core Frameworks - Remove duplicate sysfs entry 'color' from LEDs class
| commit | 8f2244c9af245ff72185c0473827125ee6b2d1a5 | [log] [tgz] |
|---|---|---|
| author | Takashi Iwai <tiwai@suse.de> | Tue Nov 21 17:23:59 2023 +0100 |
| committer | Lee Jones <lee@kernel.org> | Wed Nov 22 11:46:03 2023 +0000 |
| tree | 91fef2ce15e97c647181f938a0578839f76b1bd6 | |
| parent | b85ea95d086471afb4ad062012a4d73cd328fa86 [diff] |
leds: class: Don't expose color sysfs entry
The commit c7d80059b086 ("leds: class: Store the color index in struct
led_classdev") introduced a new sysfs entry "color" that is commonly
created for the led classdev. Unfortunately, this conflicts with the
"color" sysfs entry of already existing drivers such as Logitech HID
or System76 ACPI drivers. The driver probe fails due to the conflict,
hence it leads to a severe regression with the missing keyboard, for
example.
This patch reverts partially the change in the commit above for
removing the led class color sysfs entries again for addressing the
regressions. The newly introduced led_classdev.color field is kept as
it's already used by other driver.
Fixes: c7d80059b086 ("leds: class: Store the color index in struct led_classdev")
Reported-by: Johannes Penßel <johannes.penssel@gmail.com>
Closes: https://lore.kernel.org/r/b5646db3-acff-45aa-baef-df3f660486fb@gmail.com
Link: https://bugzilla.kernel.org/show_bug.cgi?id=218045
Link: https://bugzilla.kernel.org/show_bug.cgi?id=218155
Link: https://bugzilla.suse.com/show_bug.cgi?id=1217172
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20231121162359.9332-1-tiwai@suse.de
Signed-off-by: Lee Jones <lee@kernel.org>