| From e459dfeeb64008b2d23bdf600f03b3605dbb8152 Mon Sep 17 00:00:00 2001 |
| From: Andrey Ryabinin <aryabinin@virtuozzo.com> |
| Date: Mon, 21 Dec 2015 12:54:45 +0300 |
| Subject: ipv6/addrlabel: fix ip6addrlbl_get() |
| |
| commit e459dfeeb64008b2d23bdf600f03b3605dbb8152 upstream. |
| |
| ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded, |
| ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed, |
| ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer. |
| |
| Fix this by inverting ip6addrlbl_hold() check. |
| |
| Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.") |
| Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com> |
| Reviewed-by: Cong Wang <cwang@twopensource.com> |
| Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Zefan Li <lizefan@huawei.com> |
| --- |
| net/ipv6/addrlabel.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/net/ipv6/addrlabel.c |
| +++ b/net/ipv6/addrlabel.c |
| @@ -558,7 +558,7 @@ static int ip6addrlbl_get(struct sk_buff |
| |
| rcu_read_lock(); |
| p = __ipv6_addr_label(net, addr, ipv6_addr_type(addr), ifal->ifal_index); |
| - if (p && ip6addrlbl_hold(p)) |
| + if (p && !ip6addrlbl_hold(p)) |
| p = NULL; |
| lseq = ip6addrlbl_table.seq; |
| rcu_read_unlock(); |
