| From 1f35d04a02a652f14566f875aef3a6f2af4cb77b Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Mon, 21 Sep 2015 19:21:51 +0300 |
| Subject: devres: fix a for loop bounds check |
| |
| commit 1f35d04a02a652f14566f875aef3a6f2af4cb77b upstream. |
| |
| The iomap[] array has PCIM_IOMAP_MAX (6) elements and not |
| DEVICE_COUNT_RESOURCE (16). This bug was found using a static checker. |
| It may be that the "if (!(mask & (1 << i)))" check means we never |
| actually go past the end of the array in real life. |
| |
| Fixes: ec04b075843d ('iomap: implement pcim_iounmap_regions()') |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Acked-by: Tejun Heo <tj@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Zefan Li <lizefan@huawei.com> |
| --- |
| lib/devres.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/lib/devres.c |
| +++ b/lib/devres.c |
| @@ -390,7 +390,7 @@ void pcim_iounmap_regions(struct pci_dev |
| if (!iomap) |
| return; |
| |
| - for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { |
| + for (i = 0; i < PCIM_IOMAP_MAX; i++) { |
| if (!(mask & (1 << i))) |
| continue; |
| |
