| From b7bb110008607a915298bf0f47d25886ecb94477 Mon Sep 17 00:00:00 2001 |
| From: Johannes Berg <johannes.berg@intel.com> |
| Date: Thu, 10 Dec 2015 10:37:51 +0100 |
| Subject: rfkill: copy the name into the rfkill struct |
| |
| commit b7bb110008607a915298bf0f47d25886ecb94477 upstream. |
| |
| Some users of rfkill, like NFC and cfg80211, use a dynamic name when |
| allocating rfkill, in those cases dev_name(). Therefore, the pointer |
| passed to rfkill_alloc() might not be valid forever, I specifically |
| found the case that the rfkill name was quite obviously an invalid |
| pointer (or at least garbage) when the wiphy had been renamed. |
| |
| Fix this by making a copy of the rfkill name in rfkill_alloc(). |
| |
| Signed-off-by: Johannes Berg <johannes.berg@intel.com> |
| Signed-off-by: Zefan Li <lizefan@huawei.com> |
| --- |
| net/rfkill/core.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| --- a/net/rfkill/core.c |
| +++ b/net/rfkill/core.c |
| @@ -51,7 +51,6 @@ |
| struct rfkill { |
| spinlock_t lock; |
| |
| - const char *name; |
| enum rfkill_type type; |
| |
| unsigned long state; |
| @@ -75,6 +74,7 @@ struct rfkill { |
| struct delayed_work poll_work; |
| struct work_struct uevent_work; |
| struct work_struct sync_work; |
| + char name[]; |
| }; |
| #define to_rfkill(d) container_of(d, struct rfkill, dev) |
| |
| @@ -849,14 +849,14 @@ struct rfkill * __must_check rfkill_allo |
| if (WARN_ON(type == RFKILL_TYPE_ALL || type >= NUM_RFKILL_TYPES)) |
| return NULL; |
| |
| - rfkill = kzalloc(sizeof(*rfkill), GFP_KERNEL); |
| + rfkill = kzalloc(sizeof(*rfkill) + strlen(name) + 1, GFP_KERNEL); |
| if (!rfkill) |
| return NULL; |
| |
| spin_lock_init(&rfkill->lock); |
| INIT_LIST_HEAD(&rfkill->node); |
| rfkill->type = type; |
| - rfkill->name = name; |
| + strcpy(rfkill->name, name); |
| rfkill->ops = ops; |
| rfkill->data = ops_data; |
| |