| From 157f38f993919b648187ba341bfb05d0e91ad2f6 Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <johan@kernel.org> |
| Date: Mon, 14 Dec 2015 16:16:19 +0100 |
| Subject: spi: fix parent-device reference leak |
| |
| commit 157f38f993919b648187ba341bfb05d0e91ad2f6 upstream. |
| |
| Fix parent-device reference leak due to SPI-core taking an unnecessary |
| reference to the parent when allocating the master structure, a |
| reference that was never released. |
| |
| Note that driver core takes its own reference to the parent when the |
| master device is registered. |
| |
| Fixes: 49dce689ad4e ("spi doesn't need class_device") |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Zefan Li <lizefan@huawei.com> |
| --- |
| drivers/spi/spi.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/spi/spi.c |
| +++ b/drivers/spi/spi.c |
| @@ -846,7 +846,7 @@ struct spi_master *spi_alloc_master(stru |
| |
| device_initialize(&master->dev); |
| master->dev.class = &spi_master_class; |
| - master->dev.parent = get_device(dev); |
| + master->dev.parent = dev; |
| spi_master_set_devdata(master, &master[1]); |
| |
| return master; |
