| From 4fd2c20d964a8fb9861045f1022475c9d200d684 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <error27@gmail.com> |
| Date: Tue, 23 Mar 2010 13:35:42 -0700 |
| Subject: kcore: fix test for end of list |
| |
| From: Dan Carpenter <error27@gmail.com> |
| |
| commit 4fd2c20d964a8fb9861045f1022475c9d200d684 upstream. |
| |
| "m" is never NULL here. We need a different test for the end of list |
| condition. |
| |
| Signed-off-by: Dan Carpenter <error27@gmail.com> |
| Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> |
| Acked-by: WANG Cong <xiyou.wangcong@gmail.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Cc: Leonardo Chiquitto <leonardo.lists@gmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| fs/proc/kcore.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/proc/kcore.c |
| +++ b/fs/proc/kcore.c |
| @@ -490,7 +490,7 @@ read_kcore(struct file *file, char __use |
| } |
| read_unlock(&kclist_lock); |
| |
| - if (m == NULL) { |
| + if (&m->list == &kclist_head) { |
| if (clear_user(buffer, tsz)) |
| return -EFAULT; |
| } else if (is_vmalloc_or_module_addr((void *)start)) { |
