| From 9676fc9bb083f73bb2deefa3be3ef237b344a51e Mon Sep 17 00:00:00 2001 |
| From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <ville.syrjala@linux.intel.com> |
| Date: Wed, 17 Apr 2013 17:48:51 +0300 |
| Subject: drm/i915: Use alphabetical names for sprites |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| Add sprite_name() macro which should be used with the kind of sprites |
| that are fixed to pipes (gen4.5+). |
| |
| Also use dev_priv->num_plane to calculate the sprite index insted |
| assuming two sprites per pipe. This should make it print the right |
| name. |
| |
| Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| (cherry picked from commit 06da8da2b014d6cc98fa86e72b605e525e6d6884) |
| Signed-off-by: Darren Hart <dvhart@linux.intel.com> |
| --- |
| drivers/gpu/drm/i915/i915_drv.h | 2 ++ |
| drivers/gpu/drm/i915/intel_display.c | 8 ++++---- |
| 2 files changed, 6 insertions(+), 4 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h |
| index 47d8b68c5004..989d9a2d8bff 100644 |
| --- a/drivers/gpu/drm/i915/i915_drv.h |
| +++ b/drivers/gpu/drm/i915/i915_drv.h |
| @@ -76,6 +76,8 @@ enum plane { |
| }; |
| #define plane_name(p) ((p) + 'A') |
| |
| +#define sprite_name(p, s) ((p) * dev_priv->num_plane + (s) + 'A') |
| + |
| enum port { |
| PORT_A = 0, |
| PORT_B, |
| diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c |
| index 518c507998a6..bda32c4ebf58 100644 |
| --- a/drivers/gpu/drm/i915/intel_display.c |
| +++ b/drivers/gpu/drm/i915/intel_display.c |
| @@ -1302,8 +1302,8 @@ static void assert_sprites_disabled(struct drm_i915_private *dev_priv, |
| reg = SPCNTR(pipe, i); |
| val = I915_READ(reg); |
| WARN((val & SP_ENABLE), |
| - "sprite %d assertion failure, should be off on pipe %c but is still active\n", |
| - pipe * 2 + i, pipe_name(pipe)); |
| + "sprite %c assertion failure, should be off on pipe %c but is still active\n", |
| + sprite_name(pipe, i), pipe_name(pipe)); |
| } |
| } |
| |
| @@ -9106,8 +9106,8 @@ void intel_modeset_init(struct drm_device *dev) |
| for (j = 0; j < dev_priv->num_plane; j++) { |
| ret = intel_plane_init(dev, i, j); |
| if (ret) |
| - DRM_DEBUG_KMS("pipe %c plane %d init failed: %d\n", |
| - pipe_name(i), j, ret); |
| + DRM_DEBUG_KMS("pipe %c sprite %c init failed: %d\n", |
| + pipe_name(i), sprite_name(i, j), ret); |
| } |
| } |
| |
| -- |
| 1.8.5.rc3 |
| |