| From 2c06dd310db8286f4a44bc4a92655335499f1bec Mon Sep 17 00:00:00 2001 |
| From: Jesse Barnes <jbarnes@virtuousgeek.org> |
| Date: Thu, 25 Apr 2013 12:55:03 -0700 |
| Subject: drm/i915: warn about invalid pfit modes |
| |
| We prevent invalid ones from getting here in the first place, but it |
| doesn't hurt to have an extra sanity check. |
| |
| Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| (cherry picked from commit ab3e67f43a299b064ccd8cd230d4a006a05c8a4c) |
| Signed-off-by: Darren Hart <dvhart@linux.intel.com> |
| --- |
| drivers/gpu/drm/i915/intel_panel.c | 10 +++++++--- |
| 1 file changed, 7 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c |
| index 5cd82a5ce907..140f60d40105 100644 |
| --- a/drivers/gpu/drm/i915/intel_panel.c |
| +++ b/drivers/gpu/drm/i915/intel_panel.c |
| @@ -58,7 +58,6 @@ intel_pch_panel_fitting(struct intel_crtc *intel_crtc, |
| struct intel_crtc_config *pipe_config, |
| int fitting_mode) |
| { |
| - struct drm_i915_private *dev_priv = intel_crtc->base.dev->dev_private; |
| struct drm_display_mode *mode, *adjusted_mode; |
| int x, y, width, height; |
| |
| @@ -107,12 +106,15 @@ intel_pch_panel_fitting(struct intel_crtc *intel_crtc, |
| } |
| break; |
| |
| - default: |
| case DRM_MODE_SCALE_FULLSCREEN: |
| x = y = 0; |
| width = adjusted_mode->hdisplay; |
| height = adjusted_mode->vdisplay; |
| break; |
| + |
| + default: |
| + WARN(1, "bad panel fit mode: %d\n", fitting_mode); |
| + return; |
| } |
| |
| done: |
| @@ -267,7 +269,6 @@ void intel_gmch_panel_fitting(struct intel_crtc *intel_crtc, |
| } |
| } |
| break; |
| - default: |
| case DRM_MODE_SCALE_FULLSCREEN: |
| /* |
| * Full scaling, even if it changes the aspect ratio. |
| @@ -285,6 +286,9 @@ void intel_gmch_panel_fitting(struct intel_crtc *intel_crtc, |
| HORIZ_INTERP_BILINEAR); |
| } |
| break; |
| + default: |
| + WARN(1, "bad panel fit mode: %d\n", fitting_mode); |
| + return; |
| } |
| |
| /* 965+ wants fuzzy fitting */ |
| -- |
| 1.8.5.rc3 |
| |