| From 3c99a2602793537216ffb67e68f7cec221c9ed14 Mon Sep 17 00:00:00 2001 |
| From: Ben Widawsky <ben@bwidawsk.net> |
| Date: Fri, 31 May 2013 11:28:48 -0700 |
| Subject: drm/i915: Rename the gtt_list to global_list |
| |
| Since it will be used for the global bound/unbound list with full PPGTT, |
| this helps clarify things for upcoming code rework. |
| |
| Recommended-by: Chris Wilson <chris@chris-wilson.co.uk> |
| Signed-off-by: Ben Widawsky <ben@bwidawsk.net> |
| Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| (cherry picked from commit 35c20a60c7549b11fd1d8c5d5d7ab5b6b54d6ff9) |
| [dbasehore: Fixed conflict that seems to be due to incorrect ordering |
| of CLs] |
| Signed-off-by: Derek Basehore <dbasehore@chromium.org> |
| |
| Conflicts: |
| drivers/gpu/drm/i915/i915_gem.c |
| Signed-off-by: Darren Hart <dvhart@linux.intel.com> |
| --- |
| drivers/gpu/drm/i915/i915_debugfs.c | 11 ++++++----- |
| drivers/gpu/drm/i915/i915_drv.h | 2 +- |
| drivers/gpu/drm/i915/i915_gem.c | 21 +++++++++++---------- |
| drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++-- |
| drivers/gpu/drm/i915/i915_gem_stolen.c | 2 +- |
| drivers/gpu/drm/i915/i915_irq.c | 6 +++--- |
| 6 files changed, 24 insertions(+), 22 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c |
| index 76255a69752a..0e7e3c04d939 100644 |
| --- a/drivers/gpu/drm/i915/i915_debugfs.c |
| +++ b/drivers/gpu/drm/i915/i915_debugfs.c |
| @@ -215,7 +215,7 @@ static int i915_gem_object_info(struct seq_file *m, void* data) |
| dev_priv->mm.object_memory); |
| |
| size = count = mappable_size = mappable_count = 0; |
| - count_objects(&dev_priv->mm.bound_list, gtt_list); |
| + count_objects(&dev_priv->mm.bound_list, global_list); |
| seq_printf(m, "%u [%u] objects, %zu [%zu] bytes in gtt\n", |
| count, mappable_count, size, mappable_size); |
| |
| @@ -230,7 +230,7 @@ static int i915_gem_object_info(struct seq_file *m, void* data) |
| count, mappable_count, size, mappable_size); |
| |
| size = count = purgeable_size = purgeable_count = 0; |
| - list_for_each_entry(obj, &dev_priv->mm.unbound_list, gtt_list) { |
| + list_for_each_entry(obj, &dev_priv->mm.unbound_list, global_list) { |
| size += obj->base.size, ++count; |
| if (obj->madv == I915_MADV_DONTNEED) |
| purgeable_size += obj->base.size, ++purgeable_count; |
| @@ -238,7 +238,7 @@ static int i915_gem_object_info(struct seq_file *m, void* data) |
| seq_printf(m, "%u unbound objects, %zu bytes\n", count, size); |
| |
| size = count = mappable_size = mappable_count = 0; |
| - list_for_each_entry(obj, &dev_priv->mm.bound_list, gtt_list) { |
| + list_for_each_entry(obj, &dev_priv->mm.bound_list, global_list) { |
| if (obj->fault_mappable) { |
| size += obj->gtt_space->size; |
| ++count; |
| @@ -283,7 +283,7 @@ static int i915_gem_gtt_info(struct seq_file *m, void* data) |
| return ret; |
| |
| total_obj_size = total_gtt_size = count = 0; |
| - list_for_each_entry(obj, &dev_priv->mm.bound_list, gtt_list) { |
| + list_for_each_entry(obj, &dev_priv->mm.bound_list, global_list) { |
| if (list == PINNED_LIST && obj->pin_count == 0) |
| continue; |
| |
| @@ -1944,7 +1944,8 @@ i915_drop_caches_set(void *data, u64 val) |
| } |
| |
| if (val & DROP_UNBOUND) { |
| - list_for_each_entry_safe(obj, next, &dev_priv->mm.unbound_list, gtt_list) |
| + list_for_each_entry_safe(obj, next, &dev_priv->mm.unbound_list, |
| + global_list) |
| if (obj->pages_pin_count == 0) { |
| ret = i915_gem_object_put_pages(obj); |
| if (ret) |
| diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h |
| index 4eed8559fa90..36ed6041a259 100644 |
| --- a/drivers/gpu/drm/i915/i915_drv.h |
| +++ b/drivers/gpu/drm/i915/i915_drv.h |
| @@ -1155,7 +1155,7 @@ struct drm_i915_gem_object { |
| struct drm_mm_node *gtt_space; |
| /** Stolen memory for this object, instead of being backed by shmem. */ |
| struct drm_mm_node *stolen; |
| - struct list_head gtt_list; |
| + struct list_head global_list; |
| |
| /** This object's place on the active/inactive lists */ |
| struct list_head ring_list; |
| diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c |
| index 4c01b1b3d902..694af6db61a2 100644 |
| --- a/drivers/gpu/drm/i915/i915_gem.c |
| +++ b/drivers/gpu/drm/i915/i915_gem.c |
| @@ -176,7 +176,7 @@ i915_gem_get_aperture_ioctl(struct drm_device *dev, void *data, |
| |
| pinned = 0; |
| mutex_lock(&dev->struct_mutex); |
| - list_for_each_entry(obj, &dev_priv->mm.bound_list, gtt_list) |
| + list_for_each_entry(obj, &dev_priv->mm.bound_list, global_list) |
| if (obj->pin_count) |
| pinned += obj->gtt_space->size; |
| mutex_unlock(&dev->struct_mutex); |
| @@ -1677,7 +1677,7 @@ i915_gem_object_put_pages(struct drm_i915_gem_object *obj) |
| /* ->put_pages might need to allocate memory for the bit17 swizzle |
| * array, hence protect them from being reaped by removing them from gtt |
| * lists early. */ |
| - list_del(&obj->gtt_list); |
| + list_del(&obj->global_list); |
| |
| ops->put_pages(obj); |
| obj->pages = NULL; |
| @@ -1697,7 +1697,7 @@ __i915_gem_shrink(struct drm_i915_private *dev_priv, long target, |
| |
| list_for_each_entry_safe(obj, next, |
| &dev_priv->mm.unbound_list, |
| - gtt_list) { |
| + global_list) { |
| if ((i915_gem_object_is_purgeable(obj) || !purgeable_only) && |
| i915_gem_object_put_pages(obj) == 0) { |
| count += obj->base.size >> PAGE_SHIFT; |
| @@ -1734,7 +1734,8 @@ i915_gem_shrink_all(struct drm_i915_private *dev_priv) |
| |
| i915_gem_evict_everything(dev_priv->dev); |
| |
| - list_for_each_entry_safe(obj, next, &dev_priv->mm.unbound_list, gtt_list) |
| + list_for_each_entry_safe(obj, next, &dev_priv->mm.unbound_list, |
| + global_list) |
| i915_gem_object_put_pages(obj); |
| } |
| |
| @@ -1868,7 +1869,7 @@ i915_gem_object_get_pages(struct drm_i915_gem_object *obj) |
| if (ret) |
| return ret; |
| |
| - list_add_tail(&obj->gtt_list, &dev_priv->mm.unbound_list); |
| + list_add_tail(&obj->global_list, &dev_priv->mm.unbound_list); |
| return 0; |
| } |
| |
| @@ -2524,7 +2525,7 @@ i915_gem_object_unbind(struct drm_i915_gem_object *obj) |
| i915_gem_object_unpin_pages(obj); |
| |
| list_del(&obj->mm_list); |
| - list_move_tail(&obj->gtt_list, &dev_priv->mm.unbound_list); |
| + list_move_tail(&obj->global_list, &dev_priv->mm.unbound_list); |
| /* Avoid an unnecessary call to unbind on rebind. */ |
| obj->map_and_fenceable = true; |
| |
| @@ -2954,7 +2955,7 @@ static void i915_gem_verify_gtt(struct drm_device *dev) |
| struct drm_i915_gem_object *obj; |
| int err = 0; |
| |
| - list_for_each_entry(obj, &dev_priv->mm.gtt_list, gtt_list) { |
| + list_for_each_entry(obj, &dev_priv->mm.gtt_list, global_list) { |
| if (obj->gtt_space == NULL) { |
| printk(KERN_ERR "object found on GTT list with no space reserved\n"); |
| err++; |
| @@ -3078,7 +3079,7 @@ search_free: |
| return ret; |
| } |
| |
| - list_move_tail(&obj->gtt_list, &dev_priv->mm.bound_list); |
| + list_move_tail(&obj->global_list, &dev_priv->mm.bound_list); |
| list_add_tail(&obj->mm_list, &dev_priv->mm.inactive_list); |
| |
| obj->gtt_space = node; |
| @@ -3792,7 +3793,7 @@ void i915_gem_object_init(struct drm_i915_gem_object *obj, |
| const struct drm_i915_gem_object_ops *ops) |
| { |
| INIT_LIST_HEAD(&obj->mm_list); |
| - INIT_LIST_HEAD(&obj->gtt_list); |
| + INIT_LIST_HEAD(&obj->global_list); |
| INIT_LIST_HEAD(&obj->ring_list); |
| INIT_LIST_HEAD(&obj->exec_list); |
| |
| @@ -4538,7 +4539,7 @@ i915_gem_inactive_shrink(struct shrinker *shrinker, struct shrink_control *sc) |
| } |
| |
| cnt = 0; |
| - list_for_each_entry(obj, &dev_priv->mm.unbound_list, gtt_list) |
| + list_for_each_entry(obj, &dev_priv->mm.unbound_list, global_list) |
| if (obj->pages_pin_count == 0) |
| cnt += obj->base.size >> PAGE_SHIFT; |
| list_for_each_entry(obj, &dev_priv->mm.inactive_list, mm_list) |
| diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c |
| index 1bddf477304a..95acae13b059 100644 |
| --- a/drivers/gpu/drm/i915/i915_gem_gtt.c |
| +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c |
| @@ -439,7 +439,7 @@ void i915_gem_restore_gtt_mappings(struct drm_device *dev) |
| dev_priv->gtt.gtt_clear_range(dev, dev_priv->gtt.start / PAGE_SIZE, |
| dev_priv->gtt.total / PAGE_SIZE); |
| |
| - list_for_each_entry(obj, &dev_priv->mm.bound_list, gtt_list) { |
| + list_for_each_entry(obj, &dev_priv->mm.bound_list, global_list) { |
| i915_gem_clflush_object(obj); |
| i915_gem_gtt_bind_object(obj, obj->cache_level); |
| } |
| @@ -631,7 +631,7 @@ void i915_gem_setup_global_gtt(struct drm_device *dev, |
| dev_priv->mm.gtt_space.color_adjust = i915_gtt_color_adjust; |
| |
| /* Mark any preallocated objects as occupied */ |
| - list_for_each_entry(obj, &dev_priv->mm.bound_list, gtt_list) { |
| + list_for_each_entry(obj, &dev_priv->mm.bound_list, global_list) { |
| DRM_DEBUG_KMS("reserving preallocated space: %x + %zx\n", |
| obj->gtt_offset, obj->base.size); |
| |
| diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c |
| index bc593e353576..f713294618fe 100644 |
| --- a/drivers/gpu/drm/i915/i915_gem_stolen.c |
| +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c |
| @@ -383,7 +383,7 @@ i915_gem_object_create_stolen_for_preallocated(struct drm_device *dev, |
| obj->gtt_offset = gtt_offset; |
| obj->has_global_gtt_mapping = 1; |
| |
| - list_add_tail(&obj->gtt_list, &dev_priv->mm.bound_list); |
| + list_add_tail(&obj->global_list, &dev_priv->mm.bound_list); |
| list_add_tail(&obj->mm_list, &dev_priv->mm.inactive_list); |
| |
| return obj; |
| diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c |
| index ea396518baab..2ecf66cb26f3 100644 |
| --- a/drivers/gpu/drm/i915/i915_irq.c |
| +++ b/drivers/gpu/drm/i915/i915_irq.c |
| @@ -1681,7 +1681,7 @@ static u32 capture_pinned_bo(struct drm_i915_error_buffer *err, |
| struct drm_i915_gem_object *obj; |
| int i = 0; |
| |
| - list_for_each_entry(obj, head, gtt_list) { |
| + list_for_each_entry(obj, head, global_list) { |
| if (obj->pin_count == 0) |
| continue; |
| |
| @@ -1823,7 +1823,7 @@ static void i915_gem_record_active_context(struct intel_ring_buffer *ring, |
| if (ring->id != RCS || !error->ccid) |
| return; |
| |
| - list_for_each_entry(obj, &dev_priv->mm.bound_list, gtt_list) { |
| + list_for_each_entry(obj, &dev_priv->mm.bound_list, global_list) { |
| if ((error->ccid & PAGE_MASK) == obj->gtt_offset) { |
| ering->ctx = i915_error_object_create_sized(dev_priv, |
| obj, 1); |
| @@ -1960,7 +1960,7 @@ static void i915_capture_error_state(struct drm_device *dev) |
| list_for_each_entry(obj, &dev_priv->mm.active_list, mm_list) |
| i++; |
| error->active_bo_count = i; |
| - list_for_each_entry(obj, &dev_priv->mm.bound_list, gtt_list) |
| + list_for_each_entry(obj, &dev_priv->mm.bound_list, global_list) |
| if (obj->pin_count) |
| i++; |
| error->pinned_bo_count = i - error->active_bo_count; |
| -- |
| 1.8.5.rc3 |
| |