blob: 9095baf796a38f9ac0debfeb4fc234ade392e550 [file] [log] [blame]
From 4904237024bbd124a13e54ee5131f021f61cf58b Mon Sep 17 00:00:00 2001
From: Daniel Vetter <>
Date: Sat, 1 Jun 2013 17:16:23 +0200
Subject: drm/i915: check for strange pfit pipe assignemnt on ivb/hsw
Panel fitters on ivb/hsw are not created equal since not all of them
support the new high-quality upscaling mode. To offset this the hw
allows us to freely assign the pfits to pipes.
Since our code currently doesn't support this we might fall over when
taking over firmware state. So check for this case and WARN about it.
We can then improve the code once we've hit this in the wild. Or once
we decide to support the improved upscale modes, though that requires
global arbitrage of modeset resources across crtcs.
v2: Check for IS_GEN7 instead of IS_IVB || IS_HSW as suggested by
Paulo in his review comment.
Suggested-by: Mika Kuoppala <>
Cc: Mika Kuoppala <>
Reviewed-by: Paulo Zanoni <>
Signed-off-by: Daniel Vetter <>
(cherry picked from commit cb8b2a30b32cde5ac9053d399d084c487598976a)
Signed-off-by: Darren Hart <>
drivers/gpu/drm/i915/intel_display.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index ca0da5e3e5e5..83864bda87ac 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5803,6 +5803,14 @@ static void ironlake_get_pfit_config(struct intel_crtc *crtc,
if (tmp & PF_ENABLE) {
pipe_config->pch_pfit.pos = I915_READ(PF_WIN_POS(crtc->pipe));
pipe_config->pch_pfit.size = I915_READ(PF_WIN_SZ(crtc->pipe));
+ /* We currently do not free assignements of panel fitters on
+ * ivb/hsw (since we don't use the higher upscaling modes which
+ * differentiates them) so just WARN about this case for now. */
+ if (IS_GEN7(dev)) {
+ PF_PIPE_SEL_IVB(crtc->pipe));
+ }