| From 922bc2ad079155a1463179513bf881308329c070 Mon Sep 17 00:00:00 2001 |
| From: Paulo Zanoni <paulo.r.zanoni@intel.com> |
| Date: Wed, 12 Jun 2013 17:27:29 -0300 |
| Subject: drm/i915: invert the verbosity of intel_enable_fbc |
| |
| We currently print a DRM_DEBUG_KMS message on the happy path and don't |
| print anything on the "failed to allocate" path. On some desktop |
| environments (e.g., Unity) I see the "scheduling delayed FBC enable" |
| thousands and thousands of times on my dmesg. |
| |
| So kill the useless message for the happy case, saving a lot of dmesg |
| space, and properly signal the "kzalloc fail" case. |
| |
| Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> |
| Reviewed-by: Zoltan Nyul <zoltan.nyul@intel.com> |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| (cherry picked from commit 6cdcb5e73fba29bf115f2677c59de63f95039e2b) |
| (cherry picked from drm-intel-next-queued) |
| Signed-off-by: Darren Hart <dvhart@linux.intel.com> |
| --- |
| drivers/gpu/drm/i915/intel_pm.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c |
| index b0e4a0bd1313..bd7e682e12aa 100644 |
| --- a/drivers/gpu/drm/i915/intel_pm.c |
| +++ b/drivers/gpu/drm/i915/intel_pm.c |
| @@ -381,6 +381,7 @@ void intel_enable_fbc(struct drm_crtc *crtc, unsigned long interval) |
| |
| work = kzalloc(sizeof *work, GFP_KERNEL); |
| if (work == NULL) { |
| + DRM_ERROR("Failed to allocate FBC work structure\n"); |
| dev_priv->display.enable_fbc(crtc, interval); |
| return; |
| } |
| @@ -392,8 +393,6 @@ void intel_enable_fbc(struct drm_crtc *crtc, unsigned long interval) |
| |
| dev_priv->fbc_work = work; |
| |
| - DRM_DEBUG_KMS("scheduling delayed FBC enable\n"); |
| - |
| /* Delay the actual enabling to let pageflipping cease and the |
| * display to settle before starting the compression. Note that |
| * this delay also serves a second purpose: it allows for a |
| -- |
| 1.8.5.rc3 |
| |
