| From 8e9f9bd7cdd932b4094226fca46bbf7bf21bfc17 Mon Sep 17 00:00:00 2001 |
| From: Paulo Zanoni <paulo.r.zanoni@intel.com> |
| Date: Mon, 5 Aug 2013 17:25:55 -0300 |
| Subject: drm/i915: silence useless messages about DDI buffer translation |
| |
| These messages are not really useful since it's very easy to check |
| which mode is used for each port: The values programmed are based on |
| the port type, then assigned to the ddi_translations variable. |
| Currently we use DP mode for ports A-D and FDI mode for port E. |
| |
| Also, when we add the code to enable/disable PC8+, |
| intel_prepare_ddi_buffers will be called more often and will eat your |
| dmesg buffers. |
| |
| While at it, fix the coding style of the "for" statement above. |
| |
| Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> |
| [danvet: Pimp commit message with Paulo's more detailed explanation of |
| how the ddi translation buffer settings are computed, to answer a |
| question from Chris.] |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| |
| (cherry picked from commit f72d19f069f8efaa535aacc719d23d469b0d9f18) |
| Signed-off-by: Darren Hart <dvhart@linux.intel.com> |
| --- |
| drivers/gpu/drm/i915/intel_ddi.c | 11 ++--------- |
| 1 file changed, 2 insertions(+), 9 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c |
| index b361c0862373..b6281d9e4d62 100644 |
| --- a/drivers/gpu/drm/i915/intel_ddi.c |
| +++ b/drivers/gpu/drm/i915/intel_ddi.c |
| @@ -94,15 +94,8 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port, |
| hsw_ddi_translations_fdi : |
| hsw_ddi_translations_dp); |
| |
| - DRM_DEBUG_DRIVER("Initializing DDI buffers for port %c in %s mode\n", |
| - port_name(port), |
| - use_fdi_mode ? "FDI" : "DP"); |
| - |
| - WARN((use_fdi_mode && (port != PORT_E)), |
| - "Programming port %c in FDI mode, this probably will not work.\n", |
| - port_name(port)); |
| - |
| - for (i=0, reg=DDI_BUF_TRANS(port); i < ARRAY_SIZE(hsw_ddi_translations_fdi); i++) { |
| + for (i = 0, reg = DDI_BUF_TRANS(port); |
| + i < ARRAY_SIZE(hsw_ddi_translations_fdi); i++) { |
| I915_WRITE(reg, ddi_translations[i]); |
| reg += 4; |
| } |
| -- |
| 1.8.5.rc3 |
| |
