| From cf5c5c4e71cbef94065855caf9640ef8998797ef Mon Sep 17 00:00:00 2001 |
| From: Paulo Zanoni <paulo.r.zanoni@intel.com> |
| Date: Tue, 6 Aug 2013 18:57:14 -0300 |
| Subject: drm/i915: don't update GEN6_PMIMR when it's not needed |
| |
| I did some brief tests and the "new_val = pmimr" condition usually |
| happens a few times after exiting games. |
| |
| Note: This is also prep work to track the GEN6_PMIMR register state in |
| dev_priv->pm_imr. This happens in the next patch. |
| |
| Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> |
| Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com> |
| [danvet: Add note to explain why we want this, as per the discussion |
| between Chris and Paulo.] |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| |
| (cherry picked from commit f52ecbcf8009ef18cda86b30efd837338cd25392) |
| Signed-off-by: Darren Hart <dvhart@linux.intel.com> |
| --- |
| drivers/gpu/drm/i915/i915_irq.c | 14 +++++++++----- |
| 1 file changed, 9 insertions(+), 5 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c |
| index bb4bd21399a1..d9d3dfae26f7 100644 |
| --- a/drivers/gpu/drm/i915/i915_irq.c |
| +++ b/drivers/gpu/drm/i915/i915_irq.c |
| @@ -142,14 +142,18 @@ static void snb_update_pm_irq(struct drm_i915_private *dev_priv, |
| uint32_t interrupt_mask, |
| uint32_t enabled_irq_mask) |
| { |
| - uint32_t pmimr = I915_READ(GEN6_PMIMR); |
| - pmimr &= ~interrupt_mask; |
| - pmimr |= (~enabled_irq_mask & interrupt_mask); |
| + uint32_t pmimr, new_val; |
| |
| assert_spin_locked(&dev_priv->irq_lock); |
| |
| - I915_WRITE(GEN6_PMIMR, pmimr); |
| - POSTING_READ(GEN6_PMIMR); |
| + pmimr = new_val = I915_READ(GEN6_PMIMR); |
| + new_val &= ~interrupt_mask; |
| + new_val |= (~enabled_irq_mask & interrupt_mask); |
| + |
| + if (new_val != pmimr) { |
| + I915_WRITE(GEN6_PMIMR, new_val); |
| + POSTING_READ(GEN6_PMIMR); |
| + } |
| } |
| |
| void snb_enable_pm_irq(struct drm_i915_private *dev_priv, uint32_t mask) |
| -- |
| 1.8.5.rc3 |
| |