| From 8713156a9f074b8717aa695aac4709e197e16cc7 Mon Sep 17 00:00:00 2001 |
| From: Daniel Vetter <daniel.vetter@ffwll.ch> |
| Date: Thu, 19 Sep 2013 14:53:58 +0200 |
| Subject: drm/i915: dump crtc timings from the pipe config |
| |
| I always get royally confused how a modeline with all zeros could |
| possible pass the paranoid pipe config checker. Until I realize again |
| that we only check the crtc timings. So dump the crtc timings for the |
| adjusted mode. |
| |
| This will be even more important for 3D support where the crtc timings |
| are markedly different from the input modeline if we have |
| frame-by-frame 3d output enabled. |
| |
| Cc: Damien Lespiau <damien.lespiau@intel.com> |
| Reviewed-by: Damien Lespiau <damien.lespiau@intel.com> |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| (cherry picked from commit 644db711d3af6f7b91ce4b7e1a056a84bf34d349) |
| Signed-off-by: Darren Hart <dvhart@linux.intel.com> |
| --- |
| drivers/gpu/drm/i915/intel_display.c | 12 ++++++++++++ |
| 1 file changed, 12 insertions(+) |
| |
| diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c |
| index 07f26a9e6957..a45ff17af834 100644 |
| --- a/drivers/gpu/drm/i915/intel_display.c |
| +++ b/drivers/gpu/drm/i915/intel_display.c |
| @@ -8331,6 +8331,17 @@ compute_baseline_pipe_bpp(struct intel_crtc *crtc, |
| return bpp; |
| } |
| |
| +static void intel_dump_crtc_timings(const struct drm_display_mode *mode) |
| +{ |
| + DRM_DEBUG_KMS("crtc timings: %d %d %d %d %d %d %d %d %d, " |
| + "type: 0x%x flags: 0x%x\n", |
| + mode->clock, |
| + mode->crtc_hdisplay, mode->crtc_hsync_start, |
| + mode->crtc_hsync_end, mode->crtc_htotal, |
| + mode->crtc_vdisplay, mode->crtc_vsync_start, |
| + mode->crtc_vsync_end, mode->crtc_vtotal, mode->type, mode->flags); |
| +} |
| + |
| static void intel_dump_pipe_config(struct intel_crtc *crtc, |
| struct intel_crtc_config *pipe_config, |
| const char *context) |
| @@ -8356,6 +8367,7 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, |
| drm_mode_debug_printmodeline(&pipe_config->requested_mode); |
| DRM_DEBUG_KMS("adjusted mode:\n"); |
| drm_mode_debug_printmodeline(&pipe_config->adjusted_mode); |
| + intel_dump_crtc_timings(&pipe_config->adjusted_mode); |
| DRM_DEBUG_KMS("port clock: %d\n", pipe_config->port_clock); |
| DRM_DEBUG_KMS("pipe src size: %dx%d\n", |
| pipe_config->pipe_src_w, pipe_config->pipe_src_h); |
| -- |
| 1.8.5.rc3 |
| |
