| From 21dea0f708d1d224ac38ba42310c90e30f6cb75b Mon Sep 17 00:00:00 2001 |
| From: Jani Nikula <jani.nikula@intel.com> |
| Date: Sat, 5 Oct 2013 16:13:56 +0300 |
| Subject: drm/i915/dp: promote clock recovery failures to DRM_ERROR |
| |
| If channel equalization succeeds, there's no indication something went |
| wrong in clock recovery (unless debug is enabled). We should shout about |
| the failures and fix them instead of hiding them under the carpet. |
| |
| This has allowed bugs like [1] stay dormant for a long time. |
| |
| [1] https://bugs.freedesktop.org/show_bug.cgi?id=70117 |
| |
| Signed-off-by: Jani Nikula <jani.nikula@intel.com> |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| (cherry picked from commit 3def84b34c80518cd0375440dde8ce690795b369) |
| Signed-off-by: Darren Hart <dvhart@linux.intel.com> |
| --- |
| drivers/gpu/drm/i915/intel_dp.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c |
| index d9090d0340c7..377014783e74 100644 |
| --- a/drivers/gpu/drm/i915/intel_dp.c |
| +++ b/drivers/gpu/drm/i915/intel_dp.c |
| @@ -2507,7 +2507,7 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) |
| if (i == intel_dp->lane_count) { |
| ++loop_tries; |
| if (loop_tries == 5) { |
| - DRM_DEBUG_KMS("too many full retries, give up\n"); |
| + DRM_ERROR("too many full retries, give up\n"); |
| break; |
| } |
| intel_dp_reset_link_train(intel_dp, &DP, |
| @@ -2521,7 +2521,7 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) |
| if ((intel_dp->train_set[0] & DP_TRAIN_VOLTAGE_SWING_MASK) == voltage) { |
| ++voltage_tries; |
| if (voltage_tries == 5) { |
| - DRM_DEBUG_KMS("too many voltage retries, give up\n"); |
| + DRM_ERROR("too many voltage retries, give up\n"); |
| break; |
| } |
| } else |
| -- |
| 1.8.5.rc3 |
| |
