| From dd8de6b969acdbda36dbf4e3eec3e79163542daa Mon Sep 17 00:00:00 2001 |
| From: Wolfram Sang <wsa@the-dreams.de> |
| Date: Fri, 10 May 2013 10:16:54 +0200 |
| Subject: drivers/i2c/busses: don't check resource with devm_ioremap_resource |
| |
| devm_ioremap_resource does sanity checks on the given resource. No need to |
| duplicate this in the driver. |
| |
| Signed-off-by: Wolfram Sang <wsa@the-dreams.de> |
| (cherry picked from commit 3cc2d009bc210516c61536273b304c4f6ccd797c) |
| Signed-off-by: Darren Hart <dvhart@linux.intel.com> |
| --- |
| drivers/i2c/busses/i2c-davinci.c | 8 +------- |
| drivers/i2c/busses/i2c-designware-platdrv.c | 8 +------- |
| drivers/i2c/busses/i2c-imx.c | 6 +----- |
| drivers/i2c/busses/i2c-omap.c | 8 +------- |
| drivers/i2c/busses/i2c-rcar.c | 7 +------ |
| 5 files changed, 5 insertions(+), 32 deletions(-) |
| |
| --- a/drivers/i2c/busses/i2c-davinci.c |
| +++ b/drivers/i2c/busses/i2c-davinci.c |
| @@ -644,13 +644,6 @@ static int davinci_i2c_probe(struct plat |
| struct resource *mem, *irq; |
| int r; |
| |
| - /* NOTE: driver uses the static register mapping */ |
| - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| - if (!mem) { |
| - dev_err(&pdev->dev, "no mem resource?\n"); |
| - return -ENODEV; |
| - } |
| - |
| irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); |
| if (!irq) { |
| dev_err(&pdev->dev, "no irq resource?\n"); |
| @@ -695,6 +688,7 @@ static int davinci_i2c_probe(struct plat |
| return -ENODEV; |
| clk_prepare_enable(dev->clk); |
| |
| + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| dev->base = devm_ioremap_resource(&pdev->dev, mem); |
| if (IS_ERR(dev->base)) { |
| r = PTR_ERR(dev->base); |
| --- a/drivers/i2c/busses/i2c-designware-platdrv.c |
| +++ b/drivers/i2c/busses/i2c-designware-platdrv.c |
| @@ -87,13 +87,6 @@ static int dw_i2c_probe(struct platform_ |
| struct resource *mem; |
| int irq, r; |
| |
| - /* NOTE: driver uses the static register mapping */ |
| - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| - if (!mem) { |
| - dev_err(&pdev->dev, "no mem resource?\n"); |
| - return -EINVAL; |
| - } |
| - |
| irq = platform_get_irq(pdev, 0); |
| if (irq < 0) { |
| dev_err(&pdev->dev, "no irq resource?\n"); |
| @@ -104,6 +97,7 @@ static int dw_i2c_probe(struct platform_ |
| if (!dev) |
| return -ENOMEM; |
| |
| + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| dev->base = devm_ioremap_resource(&pdev->dev, mem); |
| if (IS_ERR(dev->base)) |
| return PTR_ERR(dev->base); |
| --- a/drivers/i2c/busses/i2c-imx.c |
| +++ b/drivers/i2c/busses/i2c-imx.c |
| @@ -498,17 +498,13 @@ static int __init i2c_imx_probe(struct p |
| |
| dev_dbg(&pdev->dev, "<%s>\n", __func__); |
| |
| - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| - if (!res) { |
| - dev_err(&pdev->dev, "can't get device resources\n"); |
| - return -ENOENT; |
| - } |
| irq = platform_get_irq(pdev, 0); |
| if (irq < 0) { |
| dev_err(&pdev->dev, "can't get irq number\n"); |
| return -ENOENT; |
| } |
| |
| + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| base = devm_ioremap_resource(&pdev->dev, res); |
| if (IS_ERR(base)) |
| return PTR_ERR(base); |
| --- a/drivers/i2c/busses/i2c-omap.c |
| +++ b/drivers/i2c/busses/i2c-omap.c |
| @@ -1087,13 +1087,6 @@ omap_i2c_probe(struct platform_device *p |
| u32 rev; |
| u16 minor, major, scheme; |
| |
| - /* NOTE: driver uses the static register mapping */ |
| - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| - if (!mem) { |
| - dev_err(&pdev->dev, "no mem resource?\n"); |
| - return -ENODEV; |
| - } |
| - |
| irq = platform_get_irq(pdev, 0); |
| if (irq < 0) { |
| dev_err(&pdev->dev, "no irq resource?\n"); |
| @@ -1106,6 +1099,7 @@ omap_i2c_probe(struct platform_device *p |
| return -ENOMEM; |
| } |
| |
| + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| dev->base = devm_ioremap_resource(&pdev->dev, mem); |
| if (IS_ERR(dev->base)) |
| return PTR_ERR(dev->base); |
| --- a/drivers/i2c/busses/i2c-rcar.c |
| +++ b/drivers/i2c/busses/i2c-rcar.c |
| @@ -665,12 +665,6 @@ static int rcar_i2c_probe(struct platfor |
| u32 bus_speed; |
| int ret; |
| |
| - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| - if (!res) { |
| - dev_err(dev, "no mmio resources\n"); |
| - return -ENODEV; |
| - } |
| - |
| priv = devm_kzalloc(dev, sizeof(struct rcar_i2c_priv), GFP_KERNEL); |
| if (!priv) { |
| dev_err(dev, "no mem for private data\n"); |
| @@ -692,6 +686,7 @@ static int rcar_i2c_probe(struct platfor |
| if (ret < 0) |
| return ret; |
| |
| + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| priv->io = devm_ioremap_resource(dev, res); |
| if (IS_ERR(priv->io)) |
| return PTR_ERR(priv->io); |