tree ba7ac34e9dbe8e0795b3704e36d5bdb88dc01faa
parent a188339ca5a396acc588e5851ed7e19f66b0ebd9
author Andreas Gruenbacher <agruenba@redhat.com> 1558117123 +0100
committer Andreas Gruenbacher <agruenba@redhat.com> 1558526984 +0200

gfs2: Fix sign extension bug in gfs2_update_stats

Commit 4d207133e9c3 changed the types of the statistic values in struct
gfs2_lkstats from s64 to u64.  Because of that, what should be a signed
value in gfs2_update_stats turned into an unsigned value.  When shifted
right, we end up with a large positive value instead of a small negative
value, which results in an incorrect variance estimate.

Fixes: 4d207133e9c3 ("gfs2: Make statistics unsigned, suitable for use with do_div()")
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Cc: stable@vger.kernel.org # v4.4+