firmware: add an extensible system data helpers
The firmware API has evolved over the years slowly, as it
grows we extend it by adding new routines or at times we extend
existing routines with more or less arguments. This doesn't scale
well, when new arguments are added to existing routines it means
we need to traverse the kernel with a slew of collateral
evolutions to adjust old driver users. The firmware API is also
now being used for things outside of the scope of what typically
would be considered "firmware", an example here is the p54 driver
enables users to provide a custom EEPROM through this interface.
Another example is optional CPU microcode updates.
There are other subsystems which would like to make use of the
APIs for similar things but have different requirements and
criteria which they'd like to be met for the requested file.
If different requirements are needed it would again mean adding
more arguments and making a slew of collateral evolutions, or
adding yet-another-new-API-call.
Instead of extending the existing firmware API even more this
provides an new extensible API which can be used to supercede the
old firmware API without causing a series of collateral evolutions
as requirements grow. This leaves the old firmware API as-is,
ignores all consideration for usermode-helpers, labels the new API
to reflect its broad use outside of the scope of firmware: system
data helpers, and builds on top of the original firmware core code.
The new extensible "system data" set of helpers accepts that there
really are only two types of requests for accessing system data:
a) synchronous requests
b) asynchronous requests
Both of these requests may have a different set of requirements
which must be met. These requirements can simply be passed as a
descriptors to each type of request. The descriptor can be extended
over time to support different requirements as the kernel evolves.
Using the new system data helpers is only necessary if you have
requirements outside of what the existing old firmware API accepts.
We encourage developers to leave the old API as-is and extend the
new descriptors and system data code to provide support for new
features.
A few simple features added as part of the new set of system data
request APIs, other than making the new API easily extensible for
the future:
- By default the kernel will free the system data file for you after
your callbacks are called, you however are allowed to request to that
you wish to keep the system data file on the descriptor. This is
dealt with by requiring a consumer callback for the system data file.
- Allow both asynchronous and synchronous request to specify that system data
files are optional. With the old APIs we had added one full API call,
request_firmware_direct() just for this purpose -- although it should be
noted another of its goal was to also skip the usermode helper.
The system data request APIs allow for you to annotate that a system
data file is optional for both synchronous or asynchronous requests
through the same two basic set of APIs.
- Usermode helpers are completely ignored, always
- The system data request APIs currently match the old synchronous firmware
API calls to refcounted firmware_class module, but it should be easy
to add support now to enable also refcounting the caller's module
should it be be needed. Likewise the system data request APIs match the
old asynchronous firmware API call and refcounts the caller's module.
In order to try to help phase out user mode helpers this makes no use of
the old user mode helper code *at all*, and if we wish to can easily
phase this code out with time then.
Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
3 files changed
